Previous day | Jump to hour: 01 02 03 04 05 06 07 08 09 10 11 12 13 14 15 16 17 18 19 20 21 22 23 | Next day

Seconds: Show Hide | Joins: Show Hide | View raw
Font: Serif Sans-Serif Monospace | Size: Small Medium Large

Click in the nick column to highlight everything a person has said.
The Logo icon identifies that the person is a core developer (has commit access).

Notice: Only Gecko based browsers prior to FF4 support the multipart/mixed "server push" method used by this log reader to auto-update. Since you do not appear to use such a browser, this page will simply show the current log, and not automatically update.

#rockbox log for 2012-03-02

00:00:05rasherI don't know how that would work
00:00:36rasherPretty sure the code is in git though
00:01:42JdGordonwe could have it push over http with their username/password?
00:02:40verbtimtranslate.rockbox.org is nice, I had to use grep/sort/vim to find the missing string
00:03:16 Quit adnap (Ping timeout: 248 seconds)
00:05:27gevaertstranslate.rockbox.org could have its own gerrit user
00:06:26JdGordonthat gets tricky with making sure the translator is credited
00:06:47gevaertsNot really. It shouldn't ever auto-push
00:06:50JdGordonactually, cant translate push directly and fluff the autho line in the commit message?
00:07:22gevaertsto master I mean
00:11:26gevaertsIt would be nice if the theme site redirected to updated versions of themes
00:18:52verbtimOk, so here is the link in gerrit: http://gerrit.rockbox.org/161
00:21:39JdGordongreat
00:21:44JdGordonare you in docs/CREDITS?
00:22:22 Join adnap [0] (~adnap@rrcs-71-42-140-57.sw.biz.rr.com)
00:23:34JdGordonverbtim: looks like no.. can you ad oyur name to that file and then ill push
00:26:31verbtimok, I am ready
00:27:05CIA-44Commit 2f5df69 in rockbox by 03Jonathan Gordon: (Author: Dimitar Dimitrov) Bulgarian translation for the remaining strings.
00:29:04 Join randumbum [0] (~IRCclient@c-71-193-176-198.hsd1.wa.comcast.net)
00:29:23 Quit Rower85 (Quit: Hmmm...)
00:29:29CIA-442f5df69 build result: All green
00:31:24 Join kadoban [0] (~kadoban@ip98-165-177-158.ph.ph.cox.net)
00:35:04 Join Sir_Leto [0] (~Anthony@unaffiliated/sir-leto/x-356438)
00:35:59Sir_LetoI just wanted to report this, the play/pause button doesn't work on bluetooth headsets.
00:36:24Sir_LetoDoes rockbox not listen for that?
00:36:49Tornei don't know that we implement the playback button api, no
00:36:50JdGordonno rockbox targets have bluetooth
00:36:53TorneJdGordon: android
00:37:05*JdGordon was being purposfully obtuse there :)
00:37:22JdGordonand i thought we do implement the mulimedia buttons?
00:37:25Sir_Letosorry, I frogot you had more than one platform. XD
00:37:25 Quit evilnick (Quit: Leaving)
00:37:40Sir_LetoThe prev/next, but not the play/pause button
00:39:02Sir_LetoAlso, why is the info on the statusbar at the top so small?
00:39:34Tornebecause the skin you're using draws it too small :)
00:39:46Sir_LetoI'm using the default skin.
00:39:55Torneyes
00:40:19Tornethe default skin is not necessarily particularly good on any given screen resolution
00:40:38Sir_LetoShould I make a skin then?
00:40:47Torneour UI system doesn't really support variable screen sizes, and good skins don't exist for all sizes
00:41:54Torneif you want
00:42:06Tornethere may be something that works better on your screen already
00:42:17Torneand some people are already working on some
00:42:47Sir_LetoWhat images do I need?
00:43:03 Quit ender` (Quit: I believe in free will, but I don't really have a choice.)
00:43:10Torneanywhere between none and loads
00:43:14Torneup to you :)
00:46:45verbtimMy Clip Zip shows up as a new device only when I plug it in while a song/music is playing. Is this normal?
00:48:46 Quit dfkt (Quit: -= SysReset 2.55=- Sic gorgiamus allos subjectatos nunc.)
00:49:36 Join mystica555_ [0] (~Mike@mystica.mobi)
00:52:12Sir_LetoRockbox doesn't seem to be able to read the album art for mp3s in android
00:52:32Sir_LetoThere are no album art images in coverflow
00:53:17JdGordondid you initialise the database?
00:56:47Sir_LetoYep
00:57:45Tornedoes the album art show up in the while playing screen?
00:57:47Torneor not there either?
00:58:12Sir_LetoNot in there either, I'll scan again
00:58:52Torneis the album art embedded in the file, or as a separate file?
00:58:56Tornewhat format is it?
00:59:11Sir_LetoI beleive it's embedded, some FLAC, and some mp3.
00:59:21Tornethe art, i meant
00:59:21Sir_Letohttp://www.rockbox.org/tracker/task/12254?project=1&type=4&order=dateopened&sort=desc How would I install this?
00:59:29Tornei don't know that we support embedded art in flac
01:00
01:00:04Tornein mp3 does work, but maybe with some caveats
01:00:10Tornemost people use separate files for art
01:00:34Sir_LetoDo I just make sure the have the same filename?
01:00:38Sir_Leto*they
01:00:53AlexPWhat format is the image?
01:01:04Torneah, yeah, are they png images by any chance?
01:01:05 Quit verbtim (Quit: Leaving)
01:01:08Tornewe only have a jpg decoder :)
01:01:16Sir_LetoI don't have any images at all, just embedded images.
01:01:20AlexPAnd the manual has a list of how to name external album art files
01:01:26AlexPAnd what format are the embedded images?
01:01:26Torneyes, but the embedded images are still in some image format
01:01:29enthdegreeis there an alternative to rockbox's menu system?
01:01:35Torneno
01:02:04enthdegreei know its just ui but is there interest in it
01:02:16enthdegreei would be willing to contribute code to it
01:02:16Tornein what specifically?
01:02:57enthdegreepredominately the ugliness factor
01:03:17Sir_LetoThat's why you make themes.
01:03:46Torneyou can change the appearance significantly with a skin, yes
01:03:50Sir_LetoI would check the forum to see if themes have been made for your device
01:03:51Torneespecially now we have skinnable lists
01:04:08Tornethe structure of the menus will still be the same though
01:04:22AlexPExcept you can hide items in the main menu now
01:04:30AlexPBut only the first level
01:04:36Torneyou can?
01:04:43Tornei must've missed that :)
01:04:45AlexPI thought so
01:04:52AlexPDidn't it get committed a few days ago?
01:04:55Tornei belive you
01:05:00Tornei just don't pay attention :p
01:05:15AlexPI more meant I might have got it wrong :)
01:05:21AlexPBut I'm fairly sure :)
01:05:33JdGordonit did
01:05:47JdGordonare we definitly freezing on monday?
01:05:52AlexPSunday
01:05:58AlexPOh, Monday for you I guess :)
01:06:02JdGordonok cool
01:06:03TorneAlexP: are you doing the release stuff?
01:06:17Tornewhoever is will probably want to talk to me about branch stuff :)
01:06:29AlexPTorne: Sort of - I rather inconveniently go away for ork on Sunday and don't come back until the Friday just before release
01:06:37Torneah
01:06:39AlexPSo gevaerts will be doing the branching bit
01:06:42JdGordonTorne: can the list of branches be trimmed from the default checkout?
01:06:43Tornewell, we should document how to do it as we go :)
01:06:48AlexPA good idea
01:06:53TorneJdGordon: You can check out less branches if you want, ye
01:07:05Tornesee git remote set-branches
01:07:16JdGordongit checkout <tab> just spits out too much
01:07:19JdGordonmostly rbutil iirc
01:07:28Torneoh, those are tags
01:07:43Tornegit by default downloads all tags that correspond to objects you have
01:07:48Tornei don't know if you can change that
01:07:56JdGordondamn, ok
01:08:07Tornethe bootloader/rbutil/etc releases are tagged on the main branch, so you will always hav them
01:08:26Tornethe actual releases of rockbox are tagged on the release branches, so if you don't fech the release branche syou also won't get those tags
01:08:29JdGordonis it too late to remove them?
01:08:56Tornewe could delete them, or move them to anothe rpart of the namespace that's not treated as a tag
01:09:08Tornethis will only affect new clones, though; tags are never re-downloaded or removed in clones
01:09:11Torneyou can delete them manually
01:09:19JdGordonok
01:09:26AlexPLocally you mean?
01:09:28Torneyeah
01:09:33Tornenot sure if it will redownload them if you delete them locally
01:09:40Tornei mean, i fthey still exist on the server.
01:09:51Torneprobably not as you already have the tagged object.
01:10:03Torneoh, wait
01:10:07Torneno, it probably will
01:10:16Tornesince you can tag objects that already exist, of course
01:10:35Torneyou could change the bash completion script to only look for branch heads, instead of tags
01:10:47Torne:)
01:11:00 Join verbtim [0] (~verbtim@212.84.240.164)
01:12:52Torneanyway, i am not averse to moving some of the old tags
01:13:08Tornethe oldest branches are already moved out of refs/heads and are under refs/oldheads
01:13:24Torneit would change git's behaviour though; refs under other paths are not treated the same by all commands
01:13:58Tornefeel free to propose a list of tags that we don't need to be there by default :)
01:15:22Sir_LetoAparently I canceled scaning before it finished
01:15:40Sir_LetoIt'll take a while to scan my 16gig card wont it?
01:15:44Tornethe database is not required to display album art in the while playing screen
01:15:49Tornei dunno how pictureflow works
01:16:13Tornebut, if it doesn't work in while playing then either it's an unsupported format (either the image itself or the way in which it's embedded) or our metadata parser is choking on it
01:16:59 Join CaptainKewl [0] (captainkew@207-237-110-248.c3-0.nyr-ubr2.nyr.ny.cable.rcn.com)
01:17:06Sir_Letookay, thanks
01:17:42Tornecheck the format with some tagging program, probably :)
01:19:14Sir_LetoI will
01:22:19 Quit enthdegree (Read error: Connection reset by peer)
01:23:16 Quit verbtim (Quit: Leaving)
01:23:47 Join factor [0] (~factor@r74-195-184-248.msk1cmtc01.mskgok.ok.dh.suddenlink.net)
01:25:56Sir_Letojpg
01:26:01Sir_Letooh well
01:26:56JdGordonwe support embeeeded jpg
01:27:46 Quit bertrik (Ping timeout: 272 seconds)
01:28:33Sir_LetoNow, it's playing static....
01:29:00 Quit anewuser (Read error: Connection reset by peer)
01:29:20 Quit zchs (Read error: Connection reset by peer)
01:30:43 Join Thra11 [0] (~thrall@46.208.29.114)
01:33:52***Saving seen data "./dancer.seen"
01:33:55 Join enthdegree [0] (~BitchX@unaffiliated/enthdegree)
01:38:56 Quit Sir_Leto (Quit: Leaving)
01:48:21 Join Strife89 [0] (~Strife89@adsl-98-80-181-175.mcn.bellsouth.net)
02:00
02:04:36 Quit Strife89 (Ping timeout: 240 seconds)
02:10:12 Join Keripo [0] (~Keripo@165.123.49.220)
02:10:55 Quit Thra11 (Quit: kthxbai)
02:13:54 Join remlap1 [0] (~Patrick@190.28.169.217.in-addr.arpa)
02:14:05 Quit randumbum (Ping timeout: 276 seconds)
02:14:53 Quit remlap1 (Client Quit)
02:15:06 Quit remlap (Ping timeout: 240 seconds)
02:30:07 Quit kadoban (Ping timeout: 245 seconds)
02:31:24 Join randumbum [0] (~IRCclient@c-71-193-176-198.hsd1.wa.comcast.net)
02:31:54 Join remlap [0] (~Patrick@190.28.169.217.in-addr.arpa)
02:34:52 Quit randumbum (Read error: Operation timed out)
02:36:27 Quit [Saint] (Read error: Connection reset by peer)
02:37:59 Join zchs [0] (~zchs@ool-ad02eb3f.dyn.optonline.net)
02:41:19 Join passstab [0] (~v@c-68-80-37-73.hsd1.pa.comcast.net)
02:44:28 Join dhrasmus [0] (~dhrasmus@c-76-105-237-23.hsd1.or.comcast.net)
03:00
03:05:30 Join anewuser [0] (~anewuser@190.207.129.184)
03:05:30 Quit anewuser (Changing host)
03:05:30 Join anewuser [0] (~anewuser@unaffiliated/anewuser)
03:17:22 Join mc2739_ [0] (~mc2739@rockbox/developer/mc2739)
03:17:58 Quit mc2739 (Ping timeout: 272 seconds)
03:20:02 Join [Saint] [0] (~Saint]@unaffiliated/saint/x-8516940)
03:25:01 Quit dhrasmus (Quit: Leaving)
03:28:37*[Saint] really needs some testes
03:28:39[Saint]http://dl.dropbox.com/u/30204410/Rockbox%20as%20an%20Application/rockbox-all-application-test.zip
03:28:54[Saint]Oh....oh my, that was unfortunate.
03:29:07*[Saint] really needs some testers
03:29:16[Saint]I have the other.
03:33:53***Saving seen data "./dancer.seen"
04:00
04:02:41 Join randumbum [0] (~IRCclient@c-71-193-176-198.hsd1.wa.comcast.net)
04:10:31[Saint]Calling all Rockbox as an Application on Android users: "I require testers!"
04:10:43[Saint]Binaries and themes available here: http://dl.dropbox.com/u/30204410/Rockbox%20as%20an%20Application/rockbox-all-application-test.zip
04:10:46[Saint]Issues can be lodged here: https://github.com/saint-lascivious/RaaA-CabbieV2/issues
04:11:48passstabrockbox is an app?
04:18:50 Quit amiconn (Disconnected by services)
04:18:50 Join amiconn_ [0] (amiconn@rockbox/developer/amiconn)
04:19:12 Nick amiconn_ is now known as amiconn (amiconn@rockbox/developer/amiconn)
04:19:49 Quit pixelma (Disconnected by services)
04:19:51 Join pixelma_ [0] (pixelma@rockbox/staff/pixelma)
04:19:53 Nick pixelma_ is now known as pixelma (pixelma@rockbox/staff/pixelma)
04:21:40DerPapstfor android yes
04:28:41 Quit dys (Ping timeout: 265 seconds)
04:28:58 Join dys [0] (~andreas@krlh-4d02b870.pool.mediaWays.net)
04:33:50 Quit passstab (Remote host closed the connection)
04:37:44 Join dhrasmus [0] (~dhrasmus@174-25-128-134.ptld.qwest.net)
04:57:11 Quit [7] (Disconnected by services)
04:57:28 Join TheSeven [0] (~TheSeven@rockbox/developer/TheSeven)
04:59:05 Quit mystica555_ (Ping timeout: 252 seconds)
05:00
05:01:32 Join Rower85 [0] (husvagn@v-413-alfarv-90.bitnet.nu)
05:03:29 Join Zarggg [0] (~zarggg@24.229.141.85.res-cmts.sm.ptd.net)
05:13:34 Join Rob2222 [0] (~Miranda@p4FFD2B3E.dip.t-dialin.net)
05:15:39 Quit anewuser (Read error: Connection reset by peer)
05:17:04 Quit Rob2223 (Ping timeout: 260 seconds)
05:33:54***Saving seen data "./dancer.seen"
05:35:14 Quit ps-auxw (Remote host closed the connection)
05:35:32 Quit DerPapst (Quit: Leaving.)
05:52:12 Join kadoban [0] (~kadoban@ip98-165-177-158.ph.ph.cox.net)
05:54:42 Join ps-auxw [0] (~arneb@p4FF7ED3E.dip.t-dialin.net)
05:57:27 Quit [Saint] (Ping timeout: 255 seconds)
06:00
06:04:26 Quit curtism (Quit: Live Long and Prosper)
06:25:11 Join BHSPitMonkey [0] (~stephen@unaffiliated/bhspitmonkey)
06:30:13 Quit zenlunatic (Ping timeout: 276 seconds)
06:48:36 Join guymann_ [0] (~charles@64-252-120-35.adsl.snet.net)
06:49:09 Quit guymann (Ping timeout: 248 seconds)
06:55:50 Quit dhrasmus (Quit: Leaving)
07:00
07:04:38 Quit antil33t (Ping timeout: 240 seconds)
07:05:10 Join antil33t [0] (~Ahurhurr@101.98.150.103)
07:06:10 Join Scr0mple [0] (~Simon@119.225.209.134)
07:09:13 Quit Scromple (Ping timeout: 276 seconds)
07:24:14 Quit enthdegree (Ping timeout: 260 seconds)
07:30:38 Quit CaptainKewl (Ping timeout: 255 seconds)
07:33:58***Saving seen data "./dancer.seen"
07:34:58 Join perrikwp_ [0] (~quassel@cpe-024-163-024-033.triad.res.rr.com)
07:37:23 Quit perrikwp (Ping timeout: 255 seconds)
07:42:23 Join Keripo1 [0] (~Keripo@165.123.49.220)
07:43:08 Quit Keripo (Ping timeout: 240 seconds)
07:52:15 Quit BHSPitMonkey (Remote host closed the connection)
07:57:19 Join antil33t| [0] (~Ahurhurr@101.98.150.103)
08:00
08:00:12 Quit antil33t (Ping timeout: 260 seconds)
08:04:14 Join antil33t [0] (~Ahurhurr@101.98.150.103)
08:05:42 Quit antil33t| (Ping timeout: 265 seconds)
08:06:33 Join GodEater_ [0] (93722cd0@rockbox/staff/GodEater)
08:06:42 Quit mshathlonxp (Ping timeout: 252 seconds)
08:16:44 Quit antil33t (Ping timeout: 260 seconds)
08:17:23 Join antil33t [0] (~Ahurhurr@101.98.150.103)
08:17:58 Quit The_prospector (Read error: Connection reset by peer)
08:20:17 Join lrp [0] (~asdf@adsl-74-160-225-84.asm.bellsouth.net)
08:23:15lrpHow can I read() a bunch of data from a data file into a big char array? it compiles but when i run the program the screen goes black or it says theres a memory error and it gives an address, or it says plugin returned error #leak-file-handles. int fd=rb->open("/myfile",O_RDONLY); char array[624100]; rb->read(fd,array,624100); rb->splashf(40,"%d",array[0]);
08:25:13 Join antil33t| [0] (~Ahurhurr@101.98.150.103)
08:28:08 Quit antil33t (Ping timeout: 240 seconds)
08:31:28JdGordonlrp: 624100 is bigger than any targets plugin buffer, im surprised it links
08:31:52JdGordonand it looks like you really should study up on c more
08:32:30lrpJdGordon why?
08:36:37lrphow can i find the size of my mp3 players buffer? is 32k the max size of a data file or the max size of an array?
08:37:32lrphow come when I make the array size 6766 the program doesnt work?
08:42:44 Join ender` [0] (~ender@foo.eternallybored.org)
08:44:32 Quit Scr0mple (Read error: Connection reset by peer)
08:48:42 Quit zchs (Remote host closed the connection)
08:58:04 Join bertrik [0] (~bertrik@rockbox/developer/bertrik)
09:00
09:33:59***Saving seen data "./dancer.seen"
09:34:09 Quit bertrik (Ping timeout: 276 seconds)
09:59:12 Quit nosa-j (Read error: Connection reset by peer)
10:00
10:01:06 Join nosa-j [0] (~m00k@adsl-74-235-42-18.clt.bellsouth.net)
10:04:11 Join pamaury [0] (~quassel@rockbox/developer/pamaury)
10:24:32pamauryis the website down ?
10:27:01 Join evilnick_ [0] (~evilnick@host217-44-129-98.range217-44.btcentralplus.com)
10:30:38 Join DerPapst [0] (~Adium@91-64-115-27-dynip.superkabel.de)
10:31:50 Join LinusN [0] (~linus@giant.haxx.se)
10:34:56evilnick_[Saint]: (for the logs) I just tried out the 480x800 version and it's broken :(
10:35:17evilnick_That is, I downloaded the .zip from your dropbox link
10:35:54evilnick_Installed the .apk in there, then extracted the theme over the top of the rockbox folder and loaded the theme
10:36:40evilnick_ANY press on the screen (even if it's to skip track) erases the currently playing information but does NOT display the popup
10:52:05 Quit kadoban (Ping timeout: 272 seconds)
11:00
11:02:55 Quit Rower85 (Read error: Connection reset by peer)
11:03:08 Join Rower85 [0] (husvagn@v-413-alfarv-90.bitnet.nu)
11:06:27 Join wodz [0] (~wodz@89-76-160-35.dynamic.chello.pl)
11:07:47wodzI'd like to separate RKW firmware loading routine put in separate file so it could be shared by rolo and bootloader. What will be the most appropriate place for .c and .h? firmware/common firmware/include ?
11:08:53 Quit antil33t| (Ping timeout: 248 seconds)
11:10:21 Join antil33t [0] (~Ahurhurr@101.98.150.103)
11:10:31 Join perrikwp [0] (~quassel@cpe-024-163-024-033.triad.res.rr.com)
11:13:15 Part lrp
11:13:37 Quit perrikwp_ (Ping timeout: 272 seconds)
11:16:28pamaurywodz: firmware/ sounds like a good place, not sure about firmware/common though. It's more target specific or driver specific
11:17:00wodzstrictly speaking it is not target specific
11:17:30wodzit just some binary packing scheme (header, and crc algo)
11:17:54wodzjust like our add format, mi4 or whatever
11:19:23pamauryis it a complicated format ?
11:20:39wodzIn general it looks like quite complicated but I want to implement only RKLD subset which is rather simple http://www.rockbox.org/wiki/RKWFileFormat
11:21:40 Quit factor (Read error: Connection reset by peer)
11:22:19pamauryI would say either firmware/rkw.c or firmware/target/arm/rk27xx/rkw.c (since it's quite rk27 specific !); plus a header in export
11:22:58pamauryIs there an official github mirror of our tree ?
11:23:02wodzanyway firmware files contain only RKLD section, upgrade images usually more
11:24:12wodzok, I'll put it in firmware/target/arm/rk27xx/rkw.c. The chance that enything else will use this format is next to 0
11:25:13pamauryyes, I can tell for sure that the rknano has a different format for example :) So it' unlikely to be used elsewhere
11:26:57wodzpamaury: btw your idea of self-moving binary is neat but using it in rolo will restrict it to rockbox RKW files only. I borrowed the idea from imx31 which allows to boot OF also through rolo
11:27:50pamaurywodz: yes, rolo just can't boot the OF on the fuze+, that would be way too complicated
11:28:33 Join rarog [0] (~chatzilla@p4FF5C7D9.dip.t-dialin.net)
11:28:58pamauryso what will you do to boot both rockbox and the OF ?
11:29:05wodzbtw. Are there any implied allignment for the buffer returned by rolo_handle = core_alloc_maximum("rolo", &filebuf_size, NULL); ?
11:29:24 Quit Rower85 (Read error: Connection reset by peer)
11:29:29pamaurydon't know, kugel knows that perhaps ?
11:30:24wodzpamaury: the device have iram but only 4k so I didn't bothered to set IRAM stuff. It contains only vectors. I simply copy there simple blob which take care of anything else
11:30:56pamauryso you are back to the original solution in a way
11:31:05wodzsortof
11:33:06 Join Rower85 [0] (husvagn@v-413-alfarv-90.bitnet.nu)
11:34:02***Saving seen data "./dancer.seen"
11:34:56pamaurybuflib.h and core_alloc.h don't say anything about alignment, you probably shouldn't expect anything
11:39:48 Join factor [0] (~factor@r74-195-184-248.msk1cmtc01.mskgok.ok.dh.suddenlink.net)
11:40:06CIA-44Commit 5bfbc64 in rockbox by 03Amaury Pouly: (Author: Jean-Louis Biasini) Fuze+: All games plugins keymaps
11:40:07wodzWe are doing byte-by-byte copying in rolo so this probably doesn't matter but I guess aligning buffer properly and using word transfers would speed things a bit
11:42:54CIA-445bfbc64 build result: All green
11:52:36rarogpamaury: OF of fuze+ has a third Endpoint, is it the MTP modus or what is it for?
11:52:49rarogbEndpointAddress 0x83 EP 3 IN
11:54:53pamauryno, the OF uses MSC in CBI mode (Control Bulk Interrupt) while rockbox uses CBO (Control Bulk Only)
11:55:22pamaurysorry BOT (Bulk Only Transport)
11:56:57pamaurythe problem probably doesn't come from this
11:57:28rarogI don't know where to search else... Luns are set correctly be OF and RB
11:57:46rarogSecond configuration of OF should be irrelevant...
11:57:54 Quit Keripo1 (Quit: Leaving.)
11:58:35pamauryand afaik, it works on other targets with windows as well; it might be some windows stupidity too
11:59:07rarogBut how to circumvent it?
11:59:37 Join lorenzo92 [0] (~chatzilla@host17-111-dynamic.21-79-r.retail.telecomitalia.it)
11:59:51rarogSetting same lun names like OF does is irrelevant, I tested this.
12:00
12:00:03gevaertsrarog: as an experiment, try changing the PID to a known working one
12:03:20 Quit lorenzo92 (Client Quit)
12:29:38 Join asdfdsfjnick [0] (~asdf@adsl-74-160-225-84.asm.bellsouth.net)
12:29:57asdfdsfjnickbitmaps pixels are gotten from top to bottom, left to right, in groups of 2 hexadecimal digits (8 bits) at a time, except the order of those 2 hex digits is swapped, right? I have a 108 x 60 pixel image that I put into bitmap that format. It's displaying wrong. what did I miss?
12:30:28asdfdsfjnickdoes the lcd_bitmap() function display differently than that? thats how the linux bash bitmap command worked. is there documentaiton on how lcd_bitmap works?
12:41:32 Quit wodz (Quit: Leaving)
12:52:54 Join Topy44 [0] (~Topy44@f049206184.adsl.alicedsl.de)
12:53:42 Quit Topy (Ping timeout: 276 seconds)
13:00
13:00:57 Quit Rower85 (Read error: Connection reset by peer)
13:23:19 Nick guymann_ is now known as guymann (~charles@64-252-120-35.adsl.snet.net)
13:26:17 Join anewuser [0] (~anewuser@190.207.129.184)
13:26:17 Quit anewuser (Changing host)
13:26:17 Join anewuser [0] (~anewuser@unaffiliated/anewuser)
13:34:04***Saving seen data "./dancer.seen"
13:39:45 Join enthdegree [0] (~BitchX@unaffiliated/enthdegree)
13:46:07 Nick mc2739_ is now known as mc2739 (~mc2739@rockbox/developer/mc2739)
13:50:35 Join Thra11 [0] (~thrall@46.208.193.171)
13:57:57 Quit enthdegree (Ping timeout: 252 seconds)
14:00
14:07:43TorneZagor: it'd be nice if we could increase the session timeout on gerrit, it's pretty easy to do as per https://groups.google.com/group/repo-discuss/browse_thread/thread/568a2df8223cc548
14:10:31 Join Rower85 [0] (husvagn@v-413-alfarv-90.bitnet.nu)
14:21:48raroggevaerts: You mean iManufacturer and iProduct?
14:22:30gevaertsyes
14:27:46 Quit Topy44 (Read error: Connection reset by peer)
14:27:57 Join Topy44 [0] (~Topy44@f049206184.adsl.alicedsl.de)
14:28:50 Quit Rower85 (Read error: Connection reset by peer)
14:33:59 Join mortalis [0] (~mortalis@77.108.98.176)
14:37:08 Join Rower85 [0] (husvagn@v-413-alfarv-90.bitnet.nu)
14:37:18 Quit Rower85 (Read error: Connection reset by peer)
14:39:00 Quit evilnick_ (Ping timeout: 276 seconds)
14:43:44 Join Rower85 [0] (husvagn@v-413-alfarv-90.bitnet.nu)
14:59:57 Join evilnick [0] (~evinick@rockbox/staff/evilnick)
15:00
15:07:16rarogpamaury: btw, one other thing I noticed, "#define USB_PRODUCT_ID 0x74e1" for Fuze+, but my OF tells lsusb, that it is 0x74e0, though I don't know if it is relevant. Or is it perhaps that two different models for two differend subtypes (lcd perhaps) exist?
15:08:06pamauryiirc, one is for usb and the other for mtp but perhaps I swap them
15:11:07rarogHm... I could try compiling it with e0 and test it on Windows, but I don't have much hope that this is what would solve the problem, seems to be too irrelevant.
15:15:19 Join T44 [0] (~Topy44@f049206184.adsl.alicedsl.de)
15:16:52 Quit Topy44 (Read error: Connection reset by peer)
15:25:22 Join y4n [0] (y4n@unaffiliated/y4ndexx)
15:27:02 Join enthdegree [0] (~BitchX@unaffiliated/enthdegree)
15:27:27 Quit rarog (Remote host closed the connection)
15:27:49 Join dfkt [0] (dfkt@unaffiliated/dfkt)
15:31:00 Quit evilnick (Ping timeout: 276 seconds)
15:34:06***Saving seen data "./dancer.seen"
15:38:26 Join TomColler [0] (~thomas@net-93-144-184-96.cust.dsl.teletu.it)
15:38:36 Part TomColler
15:46:49 Join Topy [0] (~Topy44@f049206184.adsl.alicedsl.de)
15:46:49 Quit T44 (Read error: Connection reset by peer)
15:48:37 Quit ukleinek (Ping timeout: 260 seconds)
16:00
16:01:06 Join benedikt93 [0] (~benedikt9@unaffiliated/benedikt93)
16:04:08 Join ashi [0] (~ashi___@112.93.253.1)
16:05:06 Join wodz [0] (~wodz@89-76-160-35.dynamic.chello.pl)
16:06:27 Quit parafin (Quit: So long and thanks for all the fish)
16:06:40 Join parafin [0] (parafin@paraf.in)
16:07:07wodzThat is mystery. Bootloader throws prefetch abort with some hilarious address in load_rkw() function. The very same function works just fine in rolo() in main binary.
16:08:42wodzbootloader sits at the correct address after relocation
16:09:23wodzCache disabling doesn't change anything
16:10:59kugelwodz: you can count on pointer aligned buflib_alloc() buffers
16:11:17wodzkugel: ?
16:11:31wodzcan I assume it will be word aligned?
16:12:01kugelyes
16:12:22kugelby pointer aligned I meant aligned to the size of a pointer
16:14:00wodzah, ok so if unsigned char* filebuf; rolo_handle = core_alloc_maximum("rolo", &filebuf_size, NULL); filebuf = core_get_data(rolo_handle); I don't have guarantee
16:14:29wodzor you mean the size of pointer variable (aka 32bits)
16:16:03wodzkugel, ^
16:17:20kugelI mean "sizeof (void*)" basically
16:18:10wodzso on our architectures this translates to word align at least
16:18:13 Quit asdfdsfjnick (Ping timeout: 255 seconds)
16:18:38kugelyes
16:19:58wodzIs it documented somewhere? I couldn't find answer greping the source
16:23:00kugelif buflib.h doesnt document it it isnt
16:25:38 Join perrikwp_ [0] (~quassel@cpe-024-163-024-033.triad.res.rr.com)
16:25:48wodzkugel: greping for align or (void *) gives no result so I guess it doesn't
16:26:27kugelyou grep single files instead of opening them? :)
16:27:01 Quit perrikwp (Read error: Operation timed out)
16:27:16kugelbut it doesnt seem to be in there
16:27:25wodzkugel: I opened it and couldn't spot the info so I grepped
16:35:49 Quit randumbum (Ping timeout: 252 seconds)
16:35:56 Part remlap
16:37:32 Quit Rower85 (Read error: Connection reset by peer)
16:40:18wodzha found the bug
16:41:57 Part LinusN
16:42:13 Join stoffel [0] (~quassel@pD9E42DEE.dip.t-dialin.net)
16:43:29wodz\o/: So I'll commit in the near future dualboot code for rk27xx platform + rolo stuff
16:44:36 Quit Topy (Excess Flood)
16:45:01 Join Topy [0] (~Topy44@f049206184.adsl.alicedsl.de)
16:45:41 Join Rower85 [0] (husvagn@v-413-alfarv-90.bitnet.nu)
16:47:56 Join ukleinek [0] (~ukl@2001:6f8:1178:2:21e:67ff:fe11:9c5c)
16:50:02 Join randumbum [0] (~IRCclient@c-71-193-176-198.hsd1.wa.comcast.net)
16:51:19 Quit wodz (Quit: Leaving)
16:53:56 Join rarog [0] (~chatzilla@p4FF5C7D9.dip.t-dialin.net)
16:54:32rarogpamaury: e1 was correct, it was just the situation that OF reset somehow its settings and defaultet to automatic mode, which is MTP.
16:59:10 Join T44 [0] (~Topy44@f049206184.adsl.alicedsl.de)
17:00
17:00:19rarogwhat meaning do USB endpoints have? Some kind of memory addresses for reading/writing data?
17:00:30 Quit Topy (Read error: Connection reset by peer)
17:01:34pamauryrarog: don't focus on endpoints, these are just abstract way of transporting the data.
17:02:12rarogok, so it doesn't have any meaning. OF enumerates these in a different way.
17:03:01rarogbcdDevice should be irrelevant, too
17:05:42pamaurywe don't use the same configuration has the Of anyway, so comparison is mostly irrelevant
17:05:53pamaury*as
17:06:13pamaurywhat is relevant is the mass storage configuration
17:06:30pamaurythe one partly printed on dmesg
17:07:11 Join passstab [0] (~v@c-68-80-37-73.hsd1.pa.comcast.net)
17:11:30raroghm.. ok.
17:13:58rarogI don't see relevant difference as for now, but I'll look at it later, too. dmesg of OF: http://pastebin.com/cDSwi4Kf and dmesg of RB: http://pastebin.com/UJVzYznx
17:20:55 Join asdfdsfjnick [0] (~asdf@adsl-68-217-123-127.asm.bellsouth.net)
17:21:02asdfdsfjnickI keep running out of memory with my multi-dimensional array. Can I use malloc() and free() to solve my problem? How to use them? Will this work with my pastebin code? http://pastebin.com/19ksR8eE int array=malloc(71*49*33); /*initalize array e.g. char array[5][5][5]=...;*/ /*draw pixels*/ free(array); /* re assign array vars e.g. array[1][2][3]=1...*/ /*draw pixels again*/
17:21:14 Quit Rower85 (Read error: Connection reset by peer)
17:23:31Tornewe do not have a general purpose malloc and free.
17:23:55Torneyou can get one, if you're in a plugin/codec, but they are not particularly smart and it's not the way you should write that code
17:24:36TorneYou are running out of memory becasue you are not initialising the array
17:24:43TorneAll those assignment statements take up space in your code
17:25:07TorneIf you're insisting on doing it this way (which is a really terrible way to do it as we discussed before) then you need to initialise the array:
17:25:20Tornechar a[71][49][33] = {0, 0, 0, 1, 1, 0, 0, 1, 1, ...etc}
17:25:41Tornei.e. a single list with 114807 values in it
17:26:12TorneThis will still use 115KB of ram but that will, at least, fit into the plugin buffer on most targets :p
17:27:56 Join Rower85 [0] (husvagn@v-413-alfarv-90.bitnet.nu)
17:29:46 Quit asdfdsfjnick (Killed (idoru (Spam is off topic on freenode.)))
17:29:57Tornehaha
17:32:22 Join poolyco [0] (~asddf@adsl-74-160-162-139.asm.bellsouth.net)
17:32:25poolycohello
17:34:10***Saving seen data "./dancer.seen"
17:34:43poolycoTorne ty 4 reply. sorry got discon. will initialzting the array like that use less memory than a bunch of array[1][1][1]=0;array[1][1][2]=1;...? where can I find a webpage that talks all about that?
17:35:06Torneany basic C tutorial
17:35:30poolycoTorne not really. most are hello world
17:35:45Tornehello world is typically page 1 of a basic C tutorial, yes
17:35:49Tornei suggest you read all the other pages as well :)
17:36:15poolycoTorne so will initalizing it like that use less space?
17:36:21TorneRead what I said again
17:38:23Tornealso http://justfuckinggoogleit.com/?q=c+initialize+multidimensional+array
17:41:00 Quit passstab (Ping timeout: 276 seconds)
17:42:30 Join kadoban [0] (~kadoban@ip98-165-177-158.ph.ph.cox.net)
17:47:04poolycoTorne They all say you can use either way. they dont say if one uses less memory
17:47:16TorneNo they don't
17:47:48 Quit benedikt93 (Quit: Bye ;))
17:48:51poolycoTorne the op was about using less memory
17:49:07TorneAlso: read what I said aain
17:49:18Torne16:24 < Torne> You are running out of memory becasue you are not initialising the array
17:49:21Torne16:24 < Torne> All those assignment statements take up space in your code
17:49:36 Join fml [0] (~chatzilla@manz-5f74b829.pool.mediaWays.net)
17:51:37 Quit fml (Client Quit)
17:51:53poolycoTorne are you talking about compiler running out of memory or the program?
17:52:14Tornei'm talking about the problem you are having
17:52:22TorneWhich is not either of those things :)
17:52:43poolycoTorne you are talking about neatness?
17:52:50Torneno, i am talking about why your code does not compile
17:53:00Tornei am answering the question you asked, to solve your problem
17:53:19poolycoTorne it compiles, it crashes when i make it bigger and run it
17:54:02Tornethat shouldn't happen unless your code is actually wrong and is going past the end of the array.
17:54:16Torneif you make the array too big, it should fail at link time with a linker section full problem
17:54:22Tornewhich is the error you were having when you came in here previously
17:55:12 Join passstab [0] (~v@c-68-80-37-73.hsd1.pa.comcast.net)
17:55:21AlexPpoolyco: I get the feeling that learning some C would help here
17:55:22 Quit GodEater_ (Quit: Page closed)
17:58:26poolycoTorne I tested without doing anything to the array size (71 frames). It works when i initialize 1-45 frames. at 50 frames intiialized it displays weird pixels. 55+ it gives errors. data abort at 0066104 FSR0x8 (domain 0, fault 8) address 0xE5DEF83A; prefetch abort at 600001E FSR 0x0 domain 0 faut 8>
17:58:31 Join fml [0] (~chatzilla@manz-5f74b829.pool.mediaWays.net)
17:58:47Tornethen your code is wrong
17:59:05Torneand is going outside the bounds of the array
17:59:16Torneor some similar mistake that's causing you to dereference a bad pointer.
17:59:17fmlTorne: will you be around some time? Can you help me with my git problems?
17:59:22Tornefml: i am here now
17:59:30Tornedid you see, agian, my previous response in logs?
17:59:42poolycoTorne sorry, i got disconned and lost them
17:59:45Torneyou couldn't run git show −−pretty=full becasue your irc/browser was turning them into em dashes
17:59:52Torneif you use actual hyphens i assure you it works :p
17:59:56Torneer, fuller even.
17:59:58fmlTorne: I tried to do what you said, but ...−−pretty=fuller gives an error message and does not show anything.
18:00
18:00:00TorneYKWIM
18:00:19TorneIt doesn't if you type it instead of copy and pasting from something that's helpfully typeset it for you
18:00:22Torne:)
18:00:37Torneyour response when i was idle the other day had the em dashes in it
18:00:42Torneso i assume you copypasted in both directions
18:00:43Torne:)
18:01:04fmlTorne: yes indeed! How silly of me!
18:01:27Torneit is quite hard to notice
18:01:34Tornepossibly impossible, depending on font :p
18:01:43Torneanyway, what does that show as the committer and author?
18:01:48Torneand what is the actual output from gerrit when you try to push?
18:02:01Torneplease copypaste without inserting unicode :p
18:02:12fmlTorne: Ok, but now I see that in the commit, bot the author and the commit are set to the values registered on gerrit.
18:02:38Torneso, what is the actual ouytput from gerrit?
18:03:25 Quit saratoga (Quit: Page closed)
18:05:05fmlTorne: hrm... Just now I get "fatal: The remote end hung up unexpectedly" after running "git push origin HEAD:refs/for/master"
18:05:16Tornethat means your push url is not set correctly
18:05:20Tornealmost certainly ;)
18:05:34Torneunfortunately git does not give a meaningful error for trying to push to a read only source
18:05:41Tornenothing we can really do :/
18:05:58Tornesee step 6 in http://www.rockbox.org/wiki/UsingGit#Setting_up_Gerrit
18:06:13Torneand/or run git remote -vv to check the URLs
18:06:30Tornethe fetch and push urls should be different: fetch is git:// ad push is ssh://
18:06:36Torne(it's faster that way)
18:07:22fmlTorne: ah, yes, I reset the git config and pulled the repo anew. I'll setup the key in a minute.
18:07:32Torneyou don't need to set up a new key
18:07:46Tornethe key is a property of your local user account, not the repository
18:08:10Tornei have free beer waiting, btw, so try not to take too long :p
18:08:57Torne(you will also want to repeat step 7 if you have created a new repo clone, as the commit message hook is also stored in the repo)
18:09:27 Quit DerPapst (Quit: Leaving.)
18:10:11 Quit poolyco (Killed (idoru (Spam is off topic on freenode.)))
18:11:41 Quit randumbum (Quit: ChatZilla 0.9.88 [Firefox 10.0.2/20120216101208])
18:12:13 Quit mortalis (Quit: KVIrc 4.1.1 Equilibrium http://www.kvirc.net/)
18:13:15 Quit enthdegree (Ping timeout: 244 seconds)
18:14:32 Join mshathlonxp [0] (msh@84.237.141.70)
18:15:20fmlTrying to do the step 7, but get "Agent admitted failure to sign using the key" Something is screwed up on my side :-/
18:16:20Torneyour ssh agent is broken
18:16:32Torneyou could disable it temporarily
18:16:35Torneunset SSH_AUTH_SOCK
18:16:44Tornethen git will just prompt for your key passphrase every time
18:17:06Tornei don't particularly want to work out why your ssh agent is not working right :p
18:17:38 Quit stoffel (Ping timeout: 245 seconds)
18:18:33fmlTorne: did that. scp worked. But git push complains "Permission denied (publickey)" Ah, sorry, I think you'd better go and have the free beer. We'll maybe setlle it later.
18:18:53Tornethis is a different problem, anyway
18:19:24fmlTorne: yes, my original problem was a different one than I'm having now.
18:19:38Tornei suspect that when you committed before, your git configuration was not, in fact, correct
18:19:44Torneand that the commit had the wrong email on it
18:20:01Tornesince you re-cloned everything you presumably made a new commit, which now is right
18:20:06Tornebut now there's some ssh auth problem :)
18:20:33Tornethe localuser@localhostname address you reported before is what git will use by default if you haven't set user.email
18:20:58Torneit's not used anywhere other than at commit time, so if you were seeing that address mentioned during the push that means you previously made a commit before user.email was set
18:21:10Torneit sounds like it's set now, so yeah.
18:21:59Tornework out what's brokenw ith your agent/key/etc, and try and get back tot he point where "ssh -p 29418 yourusername@gerrit.rockbox.org" works
18:22:15Torneand if you still get an error from gerrit then, actually paste me the full text o fit ;)
18:22:25Tornei am connected 24/7 so you can paste me whatever in pm any time :p
18:24:15 Join stoffel [0] (~quassel@pD9E42DEE.dip.t-dialin.net)
18:24:37kugelwhat are we going to do with the librbcodec/warble patches?
18:25:20 Join Topy [0] (~Topy44@g228174236.adsl.alicedsl.de)
18:25:26fmlTorne: that works. I get the message "Unfortunately, interactive shells are disabled"
18:27:01 Join thomasjfox [0] (~thomasjfo@rockbox/developer/thomasjfox)
18:27:07kugelfml: then it works
18:27:16 Quit Topy (Read error: Connection reset by peer)
18:28:09 Join Topy44 [0] (Topy44@f048077149.adsl.alicedsl.de)
18:28:27 Quit T44 (Ping timeout: 276 seconds)
18:29:12CIA-44Commit 9476883 in rockbox by 03Thomas Jarosch: Fix sanity check in UnwStartThumb() using the wrong register
18:29:47 Join evilnick [0] (~evinick@rockbox/staff/evilnick)
18:31:52fmlkugel: How can you tell? The push does definitely not work.
18:32:03CIA-449476883 build result: All green
18:32:37kugelfml: it means ssh authentication worked. you're naturally not permitted to access the shell on the server
18:33:13kugelif pushing still doesnt work I suspect the push url is still wrong
18:36:54 Quit FOAD (Ping timeout: 276 seconds)
18:36:55kugelfml: paste your .git/config of the rb cline
18:36:56kugelclone
18:37:16 Join bertrik [0] (~bertrik@ip117-49-211-87.adsl2.static.versatel.nl)
18:37:17 Quit bertrik (Changing host)
18:37:17 Join bertrik [0] (~bertrik@rockbox/developer/bertrik)
18:39:04fmlHua! It worked! I thank to all who helped! I now think it was a combination of wrongly set remote url, not set git config (user name and email) etc. One at a time, or all together.
18:39:40fmlNow I just have to somehow close (reject?) that test commit.
18:40:07fmlHow can I do that?
18:40:18kugelfml: which test commit?
18:40:39kugelfml: we have the sandbox repo for that kind of stuff :)
18:40:43fmlkugel: I pushed a test commit to gerrit (g162)
18:41:02 Join lebellium [0] (~chatzilla@g231084051.adsl.alicedsl.de)
18:41:53fmlkugel: pushing to sandbox worked for me the other day, I only could not push to the real rockbox repo.
18:42:12kugelI don't know how you actually abandon a change
18:42:32fmlThat will probably require a gerrit admin
18:42:47kugelI doubt
18:44:11thomasjfoxThere's an "Abandon" button when you click on your changeset
18:44:18 Join perrikwp [0] (~quassel@cpe-024-163-024-033.triad.res.rr.com)
18:45:09kugelI dont see it. can only the uploader abandon changes?
18:45:35fmlI don't see it either. Can only committers do it?
18:46:43 Quit perrikwp_ (Ping timeout: 244 seconds)
18:47:13thomasjfoxI've just seen the button when I logged in to commit my own changeset
18:47:19 Quit stoffel (Ping timeout: 260 seconds)
18:47:22thomasjfoxkugel: Probably yes
18:47:55thomasjfoxfml: Are you logging in using OpenID?
18:48:03thomasjfoxlogging in = logged in
18:48:18Tornethe uploader can abandon changes
18:48:33fmlthomasjfox: yes
18:48:41TorneAha
18:48:56TorneIf, previously, you could push changes to sandbox but not rockbox, that means that the author was wrong, but the committer was right :)
18:49:04TorneSandbox gives everyone "forge author" permission
18:49:10Torneso it doesn't care if the author is right
18:49:18Tornerockbox only gives "forge author" to committers
18:50:17Tornehm
18:50:22Tornepossibly the uplaode rcan't abandon changes, actually :)
18:50:23Tornei'm not sure.
18:50:28Torneit's nothing to do with admin, anyway
18:51:10fmlTorne: who can then?
18:51:29Torneah, no, the owner and admins can
18:51:32Tornei am mistaken :)
18:52:21Torneif you can't abandon it you are either looking in the wrong palce or not logged into the right account :)
18:52:46 Join FOAD [0] (~foad@83.161.135.61)
18:52:46 Quit FOAD (Changing host)
18:52:46 Join FOAD [0] (~foad@unaffiliated/foad)
18:53:03kugelTorne: why not all committers?
18:53:12Tornebecause gerrit's permission model doesn't have a permission for it
18:53:22Torne:)
18:53:28TorneAlso, even if it did, I don't think it matters
18:53:38kugelso we (non-admins) cannot actually reject changes?
18:53:41Tornethere's no reason to abandon someone else's change
18:53:45Tornesure you can
18:53:54Tornereview -2
18:53:58Tornerejected.
18:53:58Tornedone
18:54:18kugelis it gone from the list then?
18:54:26Tornewhat list?
18:54:46kugelopen changes
18:54:51Torneno, why should it be?
18:55:07Tornewhy does that matter at all?
18:55:10kugelto not clutter the list with rejected changes
18:55:15Torne..why does that matter?
18:55:20kugelffs
18:55:27kugelstop that
18:55:33Torneno, i'm serious
18:56:05Tornethe conclusion of the discussions about this at devcon and subsequently on irc/etc seemed to be that we are just stating that we do not care if people submit changes
18:56:12Tornethe list is irrelevant
18:56:22Torneif someone comes and asks us to look at stuff, it'll get looked at
18:56:26Torneif not, it probably won't
18:57:14kugelI don't want officially rejected clutter the list of *open* changes
18:57:19kugelI find that reasonable
18:57:21Tornethe point of "abandon" is for the author of the change to assert that they are no longer interested in trying to get this change done
18:57:45Torne(which is why they can be taken over and un-abandoned by someone else uploading)
18:57:53kugelwhen we made the conclusion I wasn't aware rejected changes couldn't be hidden
18:58:05Tornewhat difference does it make?
18:58:08fmlWhere should I look to abandon the change? I'm logged in under my only gerrit name
18:58:09Torneseriously.
18:58:13Tornelook at flyspray
18:58:18TorneThere are how many open patches there?
18:58:23TorneMost of those are, defacto, rejected
18:58:26TorneThey're still in teh list
18:58:38kugelThere are also many rejected and closed ones
18:58:39Tornefml: on the patchset
18:58:54Tornekugel: some of which are worth reopening and committing, yes
18:58:59TorneThe state is basically useless
18:59:00pixelmakugel: you can still look at them though
18:59:09TorneIf you were searching for something that was previously done you would want to search both
18:59:14Torneso, why make a distinction?
18:59:37Tornekugel: as far as i knew, we were anticipating that *nobody would ever want to look at the list of changes*, regardless of state
18:59:48TornePeople might search to see if there was a change that matched some specific query
18:59:55Torneor they might look at specific changes they were pointed at
19:00
19:00:02Tornebut I don't see any reason to ever looka t the full list
19:00:06Torneopen, closed, whatever.
19:00:17 Join lebellium_ [0] (~chatzilla@e179071011.adsl.alicedsl.de)
19:00:31Tornethis was the whole point of the *original* suggestion at devcon that we close flyspray for patches and replace it with the suggestion to email patches to the list
19:00:44Tornei.e. that they would get their chance to be seen for as lona s someone kept drawing attention to them, then they would just naturally vanish
19:00:59kugelwhat the heck. this is not my point
19:01:15Tornei proposed gerrit instead because it's a better tool for actually reviewing patches
19:01:16kugelI just don't want effectively closed stuff appear on the list of open stuff
19:01:20funmanif we can filter out '-2' patches from some list there would be a way to look at changes in progress
19:01:29kugelthat has nothing to do with why we switched to gerrit
19:01:32Tornefunman: why are -2'ed patches not in progress?
19:01:43Tornefunman: review scores apply to specific patches, not to whole changes
19:01:51Torneif they upload a new version, it will be scored 0 again.
19:02:07Torneas it should be
19:02:54Tornekugel: i don't think we have the same definition of "effectively closed"
19:02:54 Quit lebellium (Ping timeout: 276 seconds)
19:02:59 Nick lebellium_ is now known as lebellium (~chatzilla@e179071011.adsl.alicedsl.de)
19:03:08Torneok, step back, can i describe how i envision this working in the future?
19:03:19Torneand then you can comment on whether you think this is sane or not?
19:03:27funmanTorne: you talk too much, it's hard to read the logs :(
19:03:57kugelTorne: not sure. you appear to give a shit about my opinion
19:04:40kugeli don't see much point in discussing with you when your answers are basically only "does it matter" and "you're wrong"
19:05:02pixelmaeveryone take a sip of beer or whatever and calm down please?
19:05:03funmanthere should be a way to not display crappy changes to focus on on-progress patches
19:05:23Tornefunman: there is. sort by updated, whcih is the default.
19:05:27funmandoesn't mean the said crappy changes must be removed from gerrit, but they should just sit in some dark corner and still be accessible
19:05:36Tornethe longer it's been since a change was updated, the less likely it is that it matters
19:06:31Tornefunman: nothing will be removed, that's not under discussion and i believe everyone knows that (in fact it's extremely difficult to delete change sin gerrit) :)
19:06:34*kugel waits for the first "bump to the top" updates
19:07:48Tornethe reason i am saying i don't think the issue you are complaining about matters, is because the way I use the tool, and the way I xpect other people to use the tool, and the way I believed we agreed we wanted to use the tool at devcon (which you were at, no?) doesn't ever encounter the issue.
19:08:18Torneyou might disagree as to the best way to use the tool, and that's fine, that's what i'm trying to talk about
19:08:40Tornebut what you appear to be focusing on is repeating your origional assertion that the way you are using it won't work well beacuse of not being able to close changes
19:08:46Tornewhich is true, and i'm not disagreeing with that
19:09:07AlexPHow do people know who to request reviews from when they upload changes?
19:09:07kugelas I said, on the devcon I wasn't aware we'd lost the ability to hide rejected changes
19:09:28TorneAlexP: the same as when they uploaded them to flyspray. asking us
19:09:36Tornekugel: we haven't lost it
19:09:39funmanAlexP: irc / author in .c files i suppose
19:10:03AlexPAs if they don't know then it does rely on us looking at a list
19:10:11Tornekugel: what i am expecting to do, and again, what i proposed at devcon that people generally seemed to agree with, was that we periodically just abandon any change that hasn't been updated in the last X months
19:10:25Tornebecause they can, trivially, be unabandoned if someone comes back wanting to finish them
19:10:59funmanAlexP: some projects have a list of maintainers for systems (e.g. linux) but it can become outdated as code evolves and people come and go
19:11:01kugelyes and that's great.
19:11:35funmanthe default reviewer could be rockbox-dev@ though
19:11:48kugelwe also maintained such a list once upon a time IIRC :)
19:11:52AlexPfunman: Yeah, I was wondering if there would be any value to having a list with subsystems that we could say we are willing to review
19:12:07kugelfunman: not rockbox-dev
19:12:15funmani'd say no, rely on git log / irc
19:12:16fmlpixelma: have you built the manual recently? I have a fresh copy and get an error message I can't explain. tex seem to run almost to the end and then I get "*** [rockbox-build.aux] Error 1"
19:12:24AlexPfunman: If you just want to see when people open new changes gerrit will mail you that
19:12:33kugelwe have rockbox-sf for this
19:12:56funmani don't want to be aware of each new bug, what i want is a nano2g !
19:13:30Torneok, i am explaining this entirely wrong and i'm sorry. let me try something totally different: if you want to see changes that have not been reviewed yet, or reviewed positively but not committed, there are searches that will return that list.
19:13:32AlexPfml: Same here
19:13:34Tornehttp://gerrit.rockbox.org/r/#/q/status:open+CodeReview%253E%253D0,n,z
19:13:42kugelTorne: what we lost is the ability to reject (as in abandon/hiding from the open list) before the timoeut
19:13:45kugelright?
19:13:47Torne^- this is the list of changes have zero or positive review scores
19:14:01pixelmafml: no, not currently. Which manual is this? It looks like something is broken (the first run is not interrupted anymore even if there are errors, it then fails in the second run which is there for the TOC
19:14:01AlexPkugel: I think what Torne just said is what you want
19:14:20AlexPfml, pixelma: I just tried for the beast and get that
19:14:44funmanwe could have manual builds in the build farm
19:14:47Tornekugel: the mismatch here between what you're saying and what i'm saying is that you appear to think that we can meaningfully reject a change, and I don't
19:15:01AlexPpixelma, fml: H100 fails too
19:15:14Tornei cannot think of an example of a change where, the patch having been rejected, it would be impossible that any future version of the patch would be accepted
19:15:20Torneand thus, i cannot think of a reason to reject a change
19:15:31fmlAlexP: pixelma: H100 here
19:15:34Torneabandoning them is useful purely as a marker of which ones *no longer have an author pushing them*
19:15:39Tornewhich is not meant to imply they are rejected
19:15:43pixelmaAlexP, fml: hmm, the Gigabeat S online manual (which use to stop at an error) doesn't show anything obvious
19:15:47Tornejust that unless someone takes over they will not be *accepted*
19:16:06fmlAlexP: pixelma: this happened just recently I think
19:16:07kugelif there's a way to mark a change bad (e.g. -2) and have a list that hides these bad ones (e.g. only display -1 and higher) then I'm fine
19:16:18Tornewhen you say "reject" and mean "hide from the list", that's just "look at a different list"
19:16:20AlexPpixelma: It looks to be built fine if I look in manual/rockbox-build.pdf
19:16:29Torneand i gave the link for one example such search above :)
19:16:36AlexPi.e. subdir in the build dir
19:16:46kugelTorne: how did you find that list?
19:16:48Tornethough the way the score searches work is a little weird and it may give unexpected results for, say, changes that have both a positive and negative score from different people
19:16:53Tornekugel: i typed a query into the search box
19:17:19Tornethe search operators are listed here: http://gerrit.rockbox.org/r/Documentation/user-search.html
19:17:35 Join a4lem [0] (~asddf@adsl-74-160-226-120.asm.bellsouth.net)
19:17:43pixelmaAlexP, fml: no idea then. Is there some error line (starting with ! in the build output before)?
19:17:48kugelfwiw, it shows g#77 which is -1
19:17:49fs-bluebot3Gerrit review #77 at http://gerrit.rockbox.org/r/#change,77 : rbutil: Do not close the themes window after installing one by Wieland Hoffmann (changes/77/77/1)
19:17:51Torneall the lists in gerrit are just searches, and they say what seach they are at the top of the list
19:17:52a4lemhello. when i did #include <dmalloc.h> it said no such file or folder. help pls
19:17:55Tornekugel: yes, i just said
19:18:04Tornekugel: it has a +1 from a different person
19:18:09Tornetherefore it matches the >=0 criteria
19:18:09kugelah okay
19:18:14pixelmaAlexP, fml: made clean, reconfigured?
19:18:19Tornebut for display purposes the -1 takes priority
19:18:26AlexPpixelma: yep, this is all new
19:18:27Tornethe search criteria matches *any* score on the change
19:18:34Tornebut the list only displays one
19:18:47AlexPpixelma: New as in new build dir :)
19:19:04kugelTorne: it hides a lot more
19:19:07Tornea4lem: Please, stop coming here and asking us basic C questions.
19:19:18Tornekugel: it might not be quite the right query
19:19:19Torne:)
19:19:43AlexPpixelma: ! Misplaced \noalign is all I could spot
19:19:44lebelliumhey, I'd like to try the new "Add the ability to draw onto the backdrop layer " commit from JdGordon but the UI simulators are still dated 26 fev. Is there another possibility or do I have to wait until the next simulators update?
19:20:10AlexPpixelma: I'll have a shufti, I haven't tried building in ages until fml mentioned it just now
19:20:14*pixelma looks for bluebrother
19:20:14Tornekugel: ah, yeah, sorry, it's not matching changes with *no* review scores
19:20:15AlexPSo I haven't looked
19:20:26pixelmame neither
19:20:34AlexPlebellium: The sims are not provided by us
19:20:35Tornekugel: anyway, you cn constrcut pretty complicated queries.
19:20:44 Join DerPapst [0] (~Adium@91-64-115-27-dynip.superkabel.de)
19:20:52lebelliumAlexP : I know ;)
19:20:52AlexPlebellium: rasher kindly provides them, best to speak to him
19:21:04AlexPlebellium: Well why ask us then?
19:21:09kugelokay, I can restore the default list in flyspray with complicated search queries
19:21:12Tornekugel: e.g. status:open -CodeReview-2
19:21:18Tornekugel: will show open changes that do not have a -2
19:21:22Tornewhich is probably the list you wanted
19:22:11rasherlebellium: just started a manual build of it all, but it takes several hours to complete
19:22:25lebelliumrasher: okay thank you :)
19:22:50AlexPlebellium: I wasn't trying to be awkward by the way, it is just you needed to speak to rasher directly
19:23:05Tornekugel: also, if someone feels like making a gerrit html/css template, as we've been in tehory waiting for for a while, that could easily include links to any queries anyone thinks are useful
19:23:19Tornekugel: e.g. "open changes that have had no reviews"
19:23:20bertriklebellium, if you run Linux it's quite easy to compile the sims
19:23:27Torneor other similar things that might be interesting places to look
19:23:56Tornekugel: is that sufficient? i'm sorry i didn't suggest this optoin first
19:23:58lebelliumAlexP: Actually I asked here because I thought it's possible one of the guys here know how frequently the simulators are updated and actually had not noticed rasher was online here
19:24:03Tornekugel: i'm a little drunk. :)
19:24:05kugelTorne: I'll see if that makes the list I want once we have -2'd a change without abandoning
19:24:05funman'Publish and Submit' -> does 'submit' push the change to rockbox.git ?
19:24:10 Join jlbiasini [0] (~metaphys@d86-32-96-55.cust.tele2.at)
19:24:17lebelliumbertrik : windows 7 ;)
19:24:22kugeli.e. once I can verify
19:24:27Tornefunman: technically it's already in rockbox.git. it merges it to the target branch.
19:24:32Tornewhich is usually master.
19:24:49Tornewell, also it doesn't technically merge it, it's a cherry-pick
19:24:52Tornebut.. yeah.
19:24:56AlexPlebellium: They really are nothing to do with us, update schedule etc. :)
19:25:09pixelmaAlexP, fml: can't help you for the moment. The one build box I have access to currently seems to be missing a tex package
19:25:18kugelrasher: would it be possible to have the theme site push to gerrit
19:25:20kugel?
19:25:22AlexPpixelma: I'll try and have a proper look later
19:25:32kugelerr, translate site*
19:25:49pixelmaon that note, I'd like to know where "multirow.sty" is supposed to come from
19:26:12AlexPdistro?
19:26:22 Join stoffel [0] (~quassel@pD9E42DEE.dip.t-dialin.net)
19:26:23pixelmadebian AFAIK
19:26:34rasherkugel: Anything is possible I guess. I doubt I'll do anything in that area. The code is in git
19:26:36bertriktexlive-latex-extra for ubuntu
19:26:51funmanpixelma: i use synaptic and search in package description to find missing files
19:27:06AlexPpixelma: texlive-latex-extra I believe
19:27:34pixelmaoh, thanks. I have to take it to the system admin though ;)
19:29:33 Quit evilnick (Ping timeout: 276 seconds)
19:32:36kugelTorne: looks like the list I want. Should be default in my opinion
19:32:54kugelbut I can live with having a bookmark to it
19:34:11***Saving seen data "./dancer.seen"
19:35:39 Quit factor (Read error: Connection reset by peer)
19:36:21 Join dhrasmus [0] (~dhrasmus@c-98-246-192-57.hsd1.or.comcast.net)
19:37:45 Join n1s [0] (~n1s@nl118-175-223.student.uu.se)
19:37:46 Quit n1s (Changing host)
19:37:46 Join n1s [0] (~n1s@rockbox/developer/n1s)
19:38:10 Join factor [0] (~factor@r74-195-184-248.msk1cmtc01.mskgok.ok.dh.suddenlink.net)
19:39:26kugeljlbiasini: you still renamed the tex file in g#129
19:39:27fs-bluebot3Gerrit review #129 at http://gerrit.rockbox.org/r/#change,129 : Plugin mosaique PLA integration (code + manual) by Jean-Louis Biasini (changes/29/129/5)
19:39:59 Join enthdegree [0] (~BitchX@unaffiliated/enthdegree)
19:40:54jlbiasinikugel: oh :O right thx
19:46:13 Join TheLemonMan [0] (~LemonBoy@adsl-ull-253-254.45-151.net24.it)
19:48:47 Quit Thra11 (Remote host closed the connection)
19:48:56 Join randumbum [0] (~IRCclient@c-71-193-176-198.hsd1.wa.comcast.net)
19:54:32pixelmaAlexP, fml: got it fixed. The error it chokes on is the missing \\ in the wps_tags.tex change here: http://git.rockbox.org/?p=rockbox.git;a=commitdiff;h=2c71aa9#patch13 . There is another possible mistake I saw and fixed before (which probably just ends in misplaced cells) in the later change here: http://git.rockbox.org/?p=rockbox.git;a=commitdiff;h=1c1e1c0#patch3
19:55:06fmlAlexP: pixelma: this seems to be a problem with the make file to me. The tex log output (manual/rockbox-build.log) looks just fine.
19:55:12pixelmanot sure if I'm *able* to push to gerrit/git correctly though :\
19:55:34pixelmafml: nope, it builds correctly now with those changes
19:55:36pixelmafor me
19:55:50kugeljlbiasini: if you make all those patches from one branch, push to gerrit after you finished updating al changes
19:56:25kugelit looks like you happen to update changes without changing anything, I suspect it's because you push multiple times, for each change
19:56:33kugelnot sure though
19:56:33fmlpixelma: I'll fix it.
19:56:35*pixelma reminds fml of the "helpful" latex error output ;)
19:57:05pixelmaI hoped someone could walk me through git/gerrit push process
19:57:15kugelpixelma: UsingGit :)
19:57:28pixelmabut I believe I haven't set up everything yet
19:58:05kugelpixelma: it assumes only that you have installed git
19:58:25 Quit n1s (Read error: Connection timed out)
19:58:33pixelmakugel: went there a while ago but that was at home, I'm not sure where I am on that "away box"
19:59:33pixelmaand it doesn't give me confidence out of nothing in really using these tools :/
19:59:36 Quit Rower85 (Read error: Connection reset by peer)
20:00
20:01:23fmlAlexP: I've uploaded a fix (g#163) but can't commit it, I'm not in the commiters group yet
20:01:39 Join curtism [0] (~curtis@unaffiliated/programble)
20:01:42AlexPI'll submit it
20:02:12fmlAlexP: he-he, nice terminology: push, commit, submit... WHat is what? :-)
20:02:30pixelmadid anyone of you check again?
20:02:42CIA-44Commit 5db58fc in rockbox by 03Alex Parker: (Author: Alexander Levin) Manual: Fix the WPS tags table
20:03:00AlexPI didn't, no
20:03:21fmlActually, the author is pixelma, I just typed it in...
20:04:11AlexPIt uses who uploaded as author
20:04:16pixelmathat was one part
20:04:28jlbiasinikugel: I admit that I'm a little confuse about how to use git
20:04:47 Join Strife89 [0] (~Strife89@207.144.201.128)
20:05:16AlexPIt builds now, cheers pixelma
20:05:19jlbiasinito edit a change, I start from a clean tree cherry pick the commit, git commit it and push again
20:05:25CIA-445db58fc build result: All green
20:05:34jlbiasinihow am I suppose to do?
20:06:08 Join Rower85 [0] (husvagn@v-413-alfarv-90.bitnet.nu)
20:06:16 Quit Rower85 (Read error: Connection reset by peer)
20:06:25jlbiasinikugel^
20:06:25pixelmahmm, can I not update to current git without committing my changes before and get some merged file in the end?
20:06:35AlexPpixelma: git stash
20:06:39*pixelma bets this had been asked before though :\\
20:07:02AlexPThen something else to unstash afterwards
20:07:23funmanjlbiasini: just like you said
20:07:26 Join Rower85 [0] (husvagn@v-413-alfarv-90.bitnet.nu)
20:07:56 Join Keripo [0] (~Keripo@eng266.wireless-resnet.upenn.edu)
20:08:32pixelmaAlexP: git pull && git stash pop ? (Think I read that before here)
20:09:12AlexPpixelma: I think you stash then pull (rebase) then something else to unstash
20:09:47funmangit stash; git pull −−rebase; git stash pop
20:09:48pixelmayes, that question was related to part 2 and 3 of your suggestion ;)
20:09:58AlexPah right
20:10:44pixelmaok, thanks funman :)
20:15:31 Nick kugel is now known as kugelp (~kugel@rockbox/developer/kugel)
20:16:06kugelpjlbiasini: 'git rebase -i master'
20:16:15jlbiasinikugel: I yes I get what you meant! It's because I wasn't sure about this remote stuff. And finally I came to the conclusion that life was to short to wonder about remote control of demo plugin
20:16:48jlbiasiniso I made the second change you asked
20:17:18kugelp this let's you amend/edit/drop each commit individually
20:17:35jlbiasiniok!!
20:17:39jlbiasininice
20:18:02jlbiasinihow practical is git, when one know how to use it :D
20:18:04kugelpit spawns your editor with further instructions
20:20:25a4lemhow do I get rockbox to compile w/ dmalloc.h? error when compiling. i did apt-get dmalloc then in my .c file i put #include </usr/include/dmalloc.h>
20:21:10pixelmafml, AlexP: as I suspected, there's a misaligned cell in the "image tags" table there due to the other mistake. It's just a cosmetic change and I'll try to commit the fix, but would like to make a short break before (and try to check it in before the next daily build round)
20:22:25jlbiasinikugelp: so doing that I won't lost my modification on other unpushed commit?
20:23:02kugelpwhich unpushed commit?
20:23:03 Join apathor [0] (~apathor@c-24-218-104-106.hsd1.ma.comcast.net)
20:23:25 Part apathor
20:23:27kugelpyou just push after the rebate finished
20:23:52kugelpa single push updates all Gerrit tickets
20:25:12jlbiasiniI do a modif then commit it, then unstead of pushing i do 'git rebase -i master' then cherry pick another commit, edit again commit do again 'git rebase -i master' and so on and at the end just push to get everything updated?
20:25:13fmlAlexP: another patch for you to review: g#164
20:25:14fs-bluebot3Gerrit review #164 at http://gerrit.rockbox.org/r/#change,164 : Manual: Describe more generally how to customise the main menu. by Alexander Levin (changes/64/164/1)
20:25:31 Quit randumbum (Ping timeout: 244 seconds)
20:26:00kugelps/rebate/rebase/
20:26:54jlbiasinioh I did rebase is it lost then?
20:28:46 Join randumbum [0] (~IRCclient@c-71-193-176-198.hsd1.wa.comcast.net)
20:29:36AlexPfml: reviewed :)
20:30:28*jlbiasini will try to remember to read BEFORE answering :/
20:32:37 Join verbtim [0] (~verbtim@212.5.13.107)
20:34:33 Quit a4lem (Ping timeout: 276 seconds)
20:35:38funmanjlbiasini: you can fetch the commit, make changes, then git commit -a −−amend to meld in previous commit
20:36:01jlbiasinikugelp: ok it worked. And after pushing do I have to reset my tree to avoid pushing again the same commit the next time or can I just start something new?
20:36:05jlbiasiniok
20:36:15jlbiasiniwhat is the -a for?
20:36:29jlbiasiniI do commit −−amend
20:36:33funmanman git-commit explains it better than me
20:36:46jlbiasiniright sorry :/
20:37:56verbtimbubbles on the sansa clip zip doesn't look right, I am looking at build/pluginbitmaps/bubbles_background.h and cannot understand where/how the BMPWIDTH_* value gets defined
20:39:42funmanverbtim: probably from the size of bitmap in apps/plugins/bitmaps
20:42:10jlbiasinifumman: just to be sure I get it: fetch == cherry pick, means taking it from the server as is, while pull will take it and merge it with my local change?
20:42:43funmansorry you lost me
20:42:51funmanpull = fetch + merge
20:43:13funmancherry pick = apply an already fetched commit on your branch
20:43:58funmani have some experience with git but gerrit is new to me
20:45:56 Nick kugelp is now known as kugel (~kugel@rockbox/developer/kugel)
20:46:14jlbiasinithanks, I will try to learn more from myself. This quite confusing at the beginning especially with all those new words fetch, pull push and so on
20:46:20pixelmais there a way to see if something (and possibly what) was set by running "git config"?
20:46:51 Join remlap [0] (~Patrick@190.28.169.217.in-addr.arpa)
20:47:20funmancat .git/config ~/.gitconfig ?
20:47:20verbtimfunman: it's in apps/plugins/bitmaps/native/SOURCES
20:47:34gevaertspixelma: git config -l?
20:50:05pixelmathat doesn't list any user.stuff for me, so I probably hadn't run that yet on this box. Thanks
20:55:39fmlHow can I upload a new change (patch set) to an existing gerrit slot? The change is in other branch than the one the first patch was uploaded from.
20:55:43ukleinekpixelma: user.email defaults to $username@$hostname, user.name defaults to the gecos field in /etc/passwd
20:56:48gevaertsfml: make sure the new commit has the same Change-Id: line
20:58:50thomasjfoxbtw: "git am" doesn't insert the Change-Id:
20:58:56fmlHow can I do that? What file should I edit?
20:59:23 Quit Keripo (Quit: Leaving.)
20:59:34gevaertsIt's just a line in the commit message
20:59:36funmangit commit −−amend
21:00
21:00:58gevaertsBut yes, if the "old" commit is at the head of your current branch, −−amend is the easy way
21:02:05jlbiasinikugelp: ok everything pushed
21:07:10AlexPfml: ah, cool :)
21:07:13AlexPThe system works!
21:08:26pixelmacan I have multiple ssh keys on gerrit?
21:08:43gevaertsyes
21:09:18pixelmahmm, now I remember seeing something like that before..., I should have looked before asking :\
21:09:18AlexPIs there a way to apply a patch set directly, or do I need to download the diff and apply it?
21:10:07gevaertsAlexP: the gerrit page has some git command lines to copy/paste
21:10:19AlexPd'oh
21:10:32AlexPgevaerts: I even looked for that on the page but couldnt see it :)
21:10:57 Part jlbiasini
21:10:58 Quit dhrasmus (Quit: Leaving)
21:11:29fmlAnd how can I comment a new patch set (i.e. what changed compared to the prev set)?
21:12:11 Join jlbiasini [0] (~metaphys@d86-32-96-55.cust.tele2.at)
21:13:35AlexPfml: Do you want me to wait before applying that?
21:13:36 Quit stoffel (Remote host closed the connection)
21:15:11jlbiasinicould someone please merge g159 with master? It has been on FS for a few weeks now, and it's just an extended version of another patch being on FS since 2010. I cleaned the part that were just giving english as translation
21:15:12fs-bluebot3Gerrit review #159 at http://gerrit.rockbox.org/r/#change,159 : Updated some missing items for Simplified-Chinese translation (FS #12584) by Jean-Louis Biasini (changes/59/159/1)
21:16:11 Join evilnick [0] (~evilnick@rockbox/staff/evilnick)
21:16:33fmlAlexP: wait for what?
21:17:04AlexPYou to comment on it?
21:17:22AlexPI thought you were trying to work out how to :)
21:18:24fmlAlexP: no, if you understand what the difference is, I won't comment
21:18:33AlexPOK
21:19:45CIA-44Commit fa452c1 in rockbox by 03Alex Parker: (Author: Alexander Levin) Manual: Describe more generally how to customise the main menu.
21:21:11Tornefml: you can leave comments on your own patchsets, just like anyone else's
21:21:14Torneon specific lines or generally
21:22:00 Quit enthdegree (Ping timeout: 276 seconds)
21:22:24CIA-44fa452c1 build result: All green
21:23:36Tornealso, if you edit the commit message it will replace the change description
21:24:53fmlOK
21:25:13 Part fml ("Have to go")
21:25:54Tornegenerally you would be amending a previous commit when you upload a new patchset, also; if you're producing the new version in a different branch your workflow might not be sensible :)
21:26:20pixelmahrm, the ssh steps for gerrit doesn't seem to have worked this time :\
21:26:40Tornepixelma: if it says the remote end hung up you didn't set teh push url
21:26:57Tornewhich is a pretty common problem so far and it's unfortunate that git doesn't have a better error for that
21:27:01Tornesince it should know what went wrong :/
21:27:14Torne(git:// protocol almost never allows receive-pack)
21:27:16pixelmano, it says "The authenticity of host '[gerrit.rockbox.org]:29418 ([80.67.6.50]:29418)' can't be established."
21:27:23Torneoh.
21:27:32Tornethat's normal ssh known_hosts stuff
21:27:50pixelmawhich I have no idea of :\
21:27:51Tornethat'll always happen the first time you ssh to somewhere from a given machine
21:27:55Tornesay yes
21:27:58Tornethen it will remember the host's key
21:28:04Torneand only complain in future if it has changed
21:28:27pixelmaah, ok
21:28:35Tornedoes it not mention it in the instructions?
21:28:37pixelmaworked now :)
21:28:38Torneit might be good to add that
21:28:49pixelmaI haven't seen it
21:28:56Tornei probably already had the host key locally when i tested the steps in the instructions
21:29:04Tornesince they're stored in your homedir, not in the git repo
21:29:10Torneso i didn't htink of it
21:29:20Torneif you still have the text handy feel free to copypaste it in there and add it as a step :)
21:29:29pixelmait's just mentioning using ssh keyagents
21:29:50Torneit may also be nice if someone explains better, ro links to a good explanation, of how to set up a key agent :)
21:29:57Tornebecause it does get pretty annoying using git without one
21:30:05Torneespecially if you have a high entropy passphrase
21:31:52pixelmahrmm... my checkout is not in a "rockbox" folder as I chose something else because the svn checkout was still in this place
21:32:21Tornenot sure what you mean
21:32:40pixelmaso I guess I have to change the "git remote set-url −−push origin ssh://yourusername@gerrit.rockbox.org:29418/rockbox" as well
21:32:43Torneno
21:32:48Tornethe URL is on the server
21:32:48CIA-44Commit 46b34da in rockbox by 03Alex Parker: (Author: Jean-Louis Biasini) Updated some missing items for Simplified-Chinese translation (FS #12584)
21:33:02TorneNothing in git cares what the local directory is
21:33:06Torneother than the initial clone
21:33:09Torneand you cd'ing into it.
21:33:32pixelmaok, thanks
21:34:14***Saving seen data "./dancer.seen"
21:35:23CIA-4446b34da build result: All green
21:40:34kugeljlbiasini: I'll have a look tomorrow
21:41:01jhMikeSanyone interested in testing this first, have a look (it's boring crap though): http://gerrit.rockbox.org/r/#/c/166/
21:44:23 Quit y4n (Quit: PANTS OFF!)
21:47:19jlbiasinikugel: thanks
21:48:39 Join lebellium_ [0] (~chatzilla@e179071011.adsl.alicedsl.de)
21:49:43 Join n1s [0] (~n1s@nl118-175-223.student.uu.se)
21:49:43 Quit n1s (Changing host)
21:49:43 Join n1s [0] (~n1s@rockbox/developer/n1s)
21:50:36 Quit lebellium (Ping timeout: 276 seconds)
21:50:49 Nick lebellium_ is now known as lebellium (~chatzilla@e179071011.adsl.alicedsl.de)
21:52:52 Join perrikwp_ [0] (~quassel@cpe-024-163-024-033.triad.res.rr.com)
21:54:54 Quit perrikwp (Ping timeout: 244 seconds)
22:00
22:01:17 Nick kugel is now known as kugelp (~kugel@rockbox/developer/kugel)
22:01:55 Nick kugelp is now known as kugel (~kugel@rockbox/developer/kugel)
22:08:25 Join Zambezi [0] (Zulu@unaffiliated/zambezi)
22:13:44 Quit bluebrother (Disconnected by services)
22:13:45 Join bluebrother^ [0] (~dom@rockbox/developer/bluebrother)
22:16:04 Quit fs-bluebot (Ping timeout: 272 seconds)
22:17:24 Join fs-bluebot [0] (~fs-bluebo@f053152237.adsl.alicedsl.de)
22:17:53 Quit TheLemonMan (Quit: WeeChat 0.3.7)
22:21:15 Quit curtism (Quit: Live Long and Prosper)
22:26:00 Part jlbiasini
22:30:30 Quit passstab (Quit: Leaving)
22:37:01verbtimHere is a patch for bubbles for the Sansa Clip Zip: http://gerrit.rockbox.org/167
22:37:54 Join z180 [0] (02cfea52@gateway/web/freenode/ip.2.207.234.82)
22:39:38verbtimWorks on target means it works on the actual device or in the simulator?
22:39:53bertrikthe actual device
22:45:41funmanhow do i save my comments in gerrit?
22:45:53funmanso far they are "drafts"
22:46:23funmanah, in review
22:47:31verbtimfunny how the oled display has trouble displaying dark and light colours on the same line
22:50:56CIA-44Commit 57264ce in rockbox by 03Thomas Jarosch: Pandora port: Add support for the L/R shoulder buttons
22:53:27CIA-4457264ce build result: All green
23:00
23:01:34 Join passstab [0] (~v@c-68-80-37-73.hsd1.pa.comcast.net)
23:01:34 Quit Strife89 (Quit: Every time you make a typo, the errorists win.)
23:01:51 Join Strife89 [0] (~Strife89@207.144.201.128)
23:03:50pixelmaTorne: how can I see if my local commit had a "Change-Id line"?
23:04:35gevaertspixelma: git show
23:05:50pixelmaalright, thanks... and how do I end the "git show" display? :\
23:06:13*pixelma feels silly for asking all those questions :/
23:06:34gevaertsq
23:06:50gevaertsWell, probably. It depends on which pager you're using
23:07:14pixelmaq worked
23:07:35 Quit evilnick (Read error: Connection reset by peer)
23:08:26 Join Strife1989 [0] (~Strife89@207-144-19-39.cstel.net)
23:09:15 Quit Strife89 (Ping timeout: 276 seconds)
23:11:02 Join Keripo [0] (~Keripo@seas622.wireless-pennnet.upenn.edu)
23:11:08 Nick Strife1989 is now known as Strife89 (~Strife89@207-144-19-39.cstel.net)
23:12:08 Join saratoga [0] (980329e4@gateway/web/freenode/ip.152.3.41.228)
23:12:17saratogafrom the AMS manuals: " If you installed Rockbox manually you can still use Rockbox Utility for uninstallation but will not be able to do this selectively."
23:12:20saratogawhat does this mean?
23:15:26 Quit Keripo (Client Quit)
23:16:39pixelmapff, looks like gerrit e-mail address verification doesn't work with IE (sorry I use it here currently). I guess that's something only the gerrit team could change
23:20:42pixelmahooray, got the first patch on gerrit (g#168). It's only a small change and I'd like to do the final push myself but if anyone wants to comment, feel free
23:21:11pixelmahmm, not the right format for fs-bluebot it seems
23:27:02z180need to stop Rio Carbon work,it uses a SoC without ARM Core
23:29:40 Quit ender` (Quit: And I don't offend religious people, they offend themselves.-- Markus Persson (notch))
23:30:42saratogayeah, thats what the wiki says
23:31:09saratogaIIRC people have looked at it before
23:31:11 Quit passstab (Read error: Connection reset by peer)
23:31:28 Join dhrasmus [0] (~dhrasmus@c-76-105-172-58.hsd1.or.comcast.net)
23:34:15***Saving seen data "./dancer.seen"
23:41:19n1spixelma: i think it wants them without the #, like g168
23:41:20fs-bluebot3Gerrit review #168 at http://gerrit.rockbox.org/r/#change,168 : Manual: Fix misaligment in the 'Images' theme tags table. by pixelma (changes/68/168/1)
23:41:42jhMikeSg166
23:41:43fs-bluebot3Gerrit review #166 at http://gerrit.rockbox.org/r/#change,166 : Do some revisions of the PCM callback system after addition of multichannel by Michael Sevakis (changes/66/166/1)
23:41:51pixelmaaha, which is why it also triggered on nanog2
23:41:58pixelmaor so
23:42:09n1sif you put a space before the g
23:42:51*jhMikeS hopes no device has a gXXX name in the future
23:44:07pixelmayes, I've seen it happening before here. n1s, and while you are at it - maybe you could review the small change? The problem it's solving can be seen here for example: http://download.rockbox.org/daily/manual/rockbox-sansaclip/rockbox-buildap3.html#x19-361000C.20
23:45:52n1spixelma: looks obviously fine to me
23:46:08n1sthe table stuff is really stupid in latex imo
23:46:23saratogalatex tables are why i went back to word
23:46:26saratogahttp://forums.rockbox.org/index.php/topic,26767
23:46:33saratogaanyone know what that noise on pause is about?
23:46:39saratogaAFAIK there should be noting special about the fuze
23:47:17n1splease don't tak about word, i've had to use it a lot lately
23:48:59jhMikeSsaratoga: Fuzev2? I have one and have not heard such a thing so far.
23:49:05pixelman1s: agreed about the stupidity. Anyway, the reason I put the patch on gerrit first was to learn about this tool.
23:49:12saratogai have a clip+ which should be identical
23:49:17saratoganever heard it either
23:50:13jhMikeSI wonder which revision it is. Does it have the old fading? Maybe I should ask over there.
23:50:35bertrikI've heard a kind of "zzzzip"-like sound on one of my sansas, it changed when disabling the autofade feature of the ascodec
23:50:37pixelmaI can hear "disk" access on my c200 (v1) and on my phone which is a bit annoying, haven't noticed anything more than that with play/pause though
23:51:14saratogafading is done digitally and not something stupid like lowering hte volume right?
23:51:15lebelliumJdGordon: I try the new layering in my SBS but it won't load my background picture :(
23:51:17*jhMikeS notices it's a somewhat dates thread (Dec 2010)
23:51:22jhMikeS*dated
23:51:48pixelmain case of the former it's also present in the OF but not as loud (it seems)
23:51:53jhMikeSsaratoga: it is now. it used to be volume fading.
23:52:09bertriksaratoga, here's a patch to disable the autofade : http://pastebin.com/Y7CCz7wB
23:52:40jhMikeSsaratoga: are we talking about a soft dac mute or the fade on stop/pause?
23:53:03saratogafade pause i think
23:53:23saratogabertrik: thats a fade on volume change or mute?
23:54:11bertrikI've heard it on pause and unpause
23:54:33 Quit Strife89 (Quit: Pursued by a bear!)
23:55:04saratogawhat is that hardware feature supposed to do exactly?
23:56:06bertrikI think it automatically adds intermediate volume steps when changing the volume more than 1 step since the previous setting
23:57:11saratogai think on pause we actually bring the DAC to zero amplitude before we mute it
23:57:14saratogaso that shouldn't matter
23:57:21saratogaunless theres a DC offset or something
23:58:12jhMikeSfading on stop/pause doesn't that way anymore anyhow
23:58:20bertrikthe ascodec can be configured for 3 different auto-fade speeds (2/4/8 ms/step), or turn off auto-fade entirely

Previous day | Next day