Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: Merging our LCD codes
From: Daniel Stenberg (daniel_at_haxx.se)
Date: 2002-04-04


On Tue, 2 Apr 2002, Alan Korr wrote:

> >I'd suggest that you and Alan sort out how to put your recorder- sources
> >in there together with Alan's already added player-sources. I mean, they
> >should be made to re-use as much code as possible, to use the same headers
> >etc.
>
> Well, a part of my lcd.h/c can be used for JBR, so Gary can use my lcd_data
> or lcd_instruction or likes (asm optimized both for speed and space) to
> create his higher level routines. I can be present at #rockbox on IRC if he
> wants to see me.

I think it would help a lot if you would provide some headers or docs for the
functions added so far. Then everyone won't have to read through the inlined
assembler to understand what actually goes on in them. ;-)

> In my source, you must define "JBP" or "JBR" depending for which model we
> want to compile. But most of "JBR" parts are FIXME :).

Most portable programs sooner or later end up converting #ifdef TARGET checks
into #ifdef HAVE_FEATURE checks as that makes it a lot easier to create
builds for new flavours (including simulated platforms). I'd prefer to use
this method here too.

I suggest starting off with these two:

[config-player.h]
/* define which LCD we have */
#define HAVE_LCDPLAYER

[config-recorder.h]
/* define which LCD we have */
#define HAVE_LCDRECORDER

This is of course just my opinion. Others may feel differently.

-- 
  Daniel Stenberg -- Hacking Archos => http://bjorn.haxx.se/rockbox/



Page was last modified "Jan 10 2012" The Rockbox Crew
aaa