Rockbox mail archive

• Next message: Rob Ward: "(no subject)"
• Previous message: Martin Ottiger: "(no subject)"
• Maybe in reply to: Daniel Stenberg: "Re: Merging our LCD codes"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

>> Well, a part of my lcd.h/c can be used for JBR, so Gary can use
>> my lcd_data or lcd_instruction or likes (asm optimized both
>> for speed and space) to create his higher level routines.
>> I can be present at #rockbox on IRC if he wants to see me.
>
>I think it would help a lot if you would provide some headers or docs
>for the functions added so far. Then everyone won't have to read
>through the inlined assembler to understand what actually goes on
>in them. ;-)

Right :). For lcd.h, we shouldn't use inline functions (except for "lcd_start" and "lcd_stop") but use those defined in lcd.h. But okay, a documentation
should be done to help other people to use it. Personnally, due to the fact that my lcd.h is a very low API, there are very few to say and I even try to give the C equivalent in comment to explain what is done in ASM.

>> In my source, you must define "JBP" or "JBR" depending for which
>> model we want to compile. But most of "JBR" parts are FIXME :).
>
>Most portable programs sooner or later end up converting
>#ifdef TARGET checks into #ifdef HAVE_FEATURE checks
>as that makes it a lot easier to create builds for new flavours
>(including simulated platforms). I'd prefer to use this method here too.

I thought about that but it doesn't make easier the coding in our case, because there is no real generic code for each target, so having #ifdef HAVE_FEATURE is not a real gain in fact. It helps much for a target with more flexible features, not for different target.

However, I'm okay to use #ifdef HAVE_FEATURE in a future time.

>I suggest starting off with these two:
>
>[config-player.h]
>/* define which LCD we have */
>#define HAVE_LCDPLAYER
>[config-recorder.h]
>/* define which LCD we have */
>#define HAVE_LCDRECORDER

Just a precision : there is two different lcd controllers for JBP and one lcd controller for JBR.

_______________________________________________________________________
This mail was sent using http://www.pegasmail.com - Send Your Mail Now!

• Next message: Rob Ward: "(no subject)"
• Previous message: Martin Ottiger: "(no subject)"
• Maybe in reply to: Daniel Stenberg: "Re: Merging our LCD codes"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]