Rockbox mail archive

• Next message: Björn Stenberg: "Re: Configuration storage and RTC RAM"
• Previous message: Björn Stenberg: "Re: Re: Remote Control"
• In reply to: Mat Pritchard: "id3v2 vs id3v1; relative path update"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

Mat Pritchard wrote:
> OK, looking at the id3 code the other day, I notice that the id3v2 tags
> are not processed if the length specified in the header is > 300 bytes.
> My id3v2 lengths are frequently 1500 bytes or so, and therefore not
> displayed. Is there any reaon for this? I mean the id3 frame can be any
> length (256 MB from memory), but we only look at a few specific tags
> anyway. Is it possible to just parse the tags we need?

It is possible, but the current code reads the whole ID3 block to memory and processes it there. That's the reason for the size limit.

I don't want to always use disk parsing, since that takes longer and uses more power. But I would welcome code that parses the tag from disk if it doesn't fit our memory buffer.

> Also, I sent a patch to Linus RE an improvement to the absolute path
> code. Would you like me to send the patch to someone else?

Send it to the list or to me personally. Linus is currently on vacation.

-- 
Björn

• Next message: Björn Stenberg: "Re: Configuration storage and RTC RAM"
• Previous message: Björn Stenberg: "Re: Re: Remote Control"
• In reply to: Mat Pritchard: "id3v2 vs id3v1; relative path update"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]