Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: RE: Possible Filename Buffer Overrun
From: Lee Marlow (lmarlow_at_yahoo.com)
Date: 2002-07-10


It looks like it still happens on my AJBR20, too.

I noticed that TREE_MAX_FILENAMELEN is defined to be 128 in tree.c. The
actual filename looks like it can come from tree.c and playlist.c.
Buffer overruns aren't my thing, so I'm not sure where to start.

When we looked into this last week, we found that the maximum length for
a path in FAT32 is 260. The filename can be 256 characters at most,
leaving only 4 characters for any directory info. Possibly 256 + "C:\" +
NULL. (http://www.systweak.com/fat32/fat12.htm)

-----Original Message-----
From: owner-rockbox_at_cool.haxx.se [mailto:owner-rockbox_at_cool.haxx.se] On
Behalf Of Stuart Tedford
Sent: Wednesday, July 10, 2002 9:09 AM
To: 'rockbox_at_cool.haxx.se'
Subject: RE: Possible Filename Buffer Overrun

>
> This happened to me as well. What version of Rockbox are you running?
> Linus committed a fix on 7/3 that should have fixed it.
>

I'm running 20020706.

Speaking of which, is there any way of knowing exactly what build you
are
running, without keeping track of it yourself like I do?

If not could we use the __DATE__ and __TIME__ macros to store the build
date
in the version string instead of just "cvs"?

Stu.



Page was last modified "Jan 10 2012" The Rockbox Crew
aaa