Rockbox mail archive

• Next message: Uwe Freese: "actual file marking while playing a dir (bug?)"
• Previous message: Eric Linenberg: "recorder directory patch."
• In reply to: Brian King: "[PATCH] WPS tweak"
• Next in thread: Magnus Holmgren: "Re: [PATCH] WPS tweak"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

On Mon, 5 Aug 2002, Brian King wrote:

> Here is a small WPS patch. It takes the excellent patch Magnus submitted
> and adds a couple tweaks.

I haven't tested your patch yet myself to see how it works in real life, but
I have some minor nits regarding the code:

strrtok_r() - this is a very "official looking" function that might very
well be useful to others, so this should go into the firmware/common/
directory imho.

Possibly we could do the same with the strfmt() function you use. I'd suggest
a better name in that case though.

The firmware/API file is also lagging behind terribly and should be updated
to contain the full actual firmware API available. Any taker?

-- 
  Daniel "Bagder" Stenberg -- http://bjorn.haxx.se/rockbox/

• Next message: Uwe Freese: "actual file marking while playing a dir (bug?)"
• Previous message: Eric Linenberg: "recorder directory patch."
• In reply to: Brian King: "[PATCH] WPS tweak"
• Next in thread: Magnus Holmgren: "Re: [PATCH] WPS tweak"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]