Rockbox mail archive
Subject: Re: [Patch] EQ Settings for Player + Recorder
From: Justin Heiner (jheiner_at_yahoo.com)
Personally, I think there should be a "Default" EQ Setting, that sets both the
treble and bass to +7dB. The Flat setting (0dB) is too little for a default,
and headphone has too much bass as a default IMHO.
--- Uwe Freese <mail_at_uwe-freese.de> wrote:
> I took the Patch from Justin Heiner (thanks!) and "completed" it for the
> recorder. Here it works well. I really hope that it goes into the CVS
> - Settings also for Recorder
> - only 3 Settings: User, Headphones, Flat (I think they are enough and
> the five were for demonstration only)
> - "User" is saved to RTC/Disk
> - The Load EQ Settings entry is at the end of the menu now (on recorder
> it was not)
> What it's not done in this patch and should be added after it is in the cvs
> version (I doesn't make sense that I change e.g. settings.c now):
> - save & load the last EQ Settings mode to the RTC/Disk (only 2 bit)
> - if the user changes bass/... setting (after loading a preset),
> the "user" settings must be loaded completely (not only bass/...)
> - maybe displaying the current setting in the menu?
> - should AVC also be changed with the settings? (I think not)
> The patch is against current cvs version.
> Bye, Uwe.
> ATTACHMENT part 2 application/octet-stream name=sound_menu.diff
Do You Yahoo!?
HotJobs - Search Thousands of New Jobs
Page was last modified "Jan 10 2012" The Rockbox Crew