Rockbox mail archive

• Next message: Mike Soultanian: "volume numbers"
• Previous message: Uwe Freese: "Re[6]: Load time lags"
• In reply to: Björn Stenberg: "Re: cvs: firmware/drivers lcd.c,1.76,1.77 lcd.h,1.21,1.22"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

Björn Stenberg wrote:
> Markus Braun wrote:
>
>>+ if (x>LCD_WIDTH) return;
>>+ if (y>LCD_HEIGHT) return;
>>+
>>+ if (x+nx>LCD_WIDTH) nx=LCD_WIDTH-x;
>>+ if (y+ny>LCD_HEIGHT) ny=LCD_HEIGHT-y;
>
>
> Please dont "save lines" by putting condition and action on the same line like this.
> It may look simpler, but it actually makes the code harder to scan.

... and please do not save "spaces", they come for free on most editors:

if (x + nx > LCD_WIDTH)
        nx = LCD_WIDTH - x;

Youdonotwritelikethisinnormallifedoyou ?

Regards,

Vladimir

• Next message: Mike Soultanian: "volume numbers"
• Previous message: Uwe Freese: "Re[6]: Load time lags"
• In reply to: Björn Stenberg: "Re: cvs: firmware/drivers lcd.c,1.76,1.77 lcd.h,1.21,1.22"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]