Rockbox mail archive

• Next message: ach_at_buteo.org: "Re: Re[2]: HDD read ahead cache"
• Previous message: Robert Hak: "Re[2]: Hostility on this list :-("
• In reply to: Hardeep Sidhu: "Re: [PATCH] Fast-Forward/Rewind"
• Next in thread: Hardeep Sidhu: "Re: [PATCH] Fast-Forward/Rewind"
• Reply: Hardeep Sidhu: "Re: [PATCH] Fast-Forward/Rewind"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

Almost there Hardeep :) That patch only works for me if I'm only near the end
of the song already (i guess that means it's only working if you're fast
forwarding within the buffer). If I do it from say, the start of the song, then
it doesn't work (does the same thing as before).

-Justin

--- Hardeep Sidhu <hardeeps_at_pobox.com> wrote:
> > > The patch below implements fast-forward and rewind.
> >
> > I merged and committed the patch. I changed it so the search time is always
> displayed on players, overwriting whatever was there before, then restoring
> the
> display on key release.
>
> Cool.
>
> > > I have only tested the patch on my AJBR6 and am anxious to hear how well
> it
> > > works on other players/recorders.
> >
> > It works nicely on my rec20 and player-old, so I'd say it works good.
> >
> > There are some issues, though. When searching close to the end of a track,
> sometimes the track change is not recognised and the display shows wrong
> data.
>
> The patch below fixes this problem.
>
> > > TODO:
> > > - Store the step size setting
> > > - Simulator implementation
> >
> > I'll take care of it.
>
> Thanks!
>
> -Hardeep
>
> Index: firmware/mpeg.c
> ===================================================================
> RCS file: /cvsroot/rockbox/firmware/mpeg.c,v
> retrieving revision 1.89
> diff -u -b -r1.89 mpeg.c
> --- firmware/mpeg.c 14 Aug 2002 21:29:17 -0000 1.89
> +++ firmware/mpeg.c 15 Aug 2002 06:11:08 -0000
> @@ -910,6 +910,17 @@
> playing = true;
> last_dma_tick = current_tick;
> init_dma();
> +
> + if (num_tracks_in_memory() > 1)
> + {
> + /* Make sure we don't cross track boundaries */
> + if ((int)(id3->filesize-newpos) <
> last_dma_chunk_size)
> + {
> + last_dma_chunk_size = id3->filesize - newpos;
> + DTCR3 = last_dma_chunk_size & 0xffff;
> + }
> + }
> +
> start_dma();
> }
> else
>

__________________________________________________
Do You Yahoo!?
HotJobs - Search Thousands of New Jobs
http://www.hotjobs.com

• Next message: ach_at_buteo.org: "Re: Re[2]: HDD read ahead cache"
• Previous message: Robert Hak: "Re[2]: Hostility on this list :-("
• In reply to: Hardeep Sidhu: "Re: [PATCH] Fast-Forward/Rewind"
• Next in thread: Hardeep Sidhu: "Re: [PATCH] Fast-Forward/Rewind"
• Reply: Hardeep Sidhu: "Re: [PATCH] Fast-Forward/Rewind"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]