Rockbox mail archive

• Next message: Uwe Freese: "charging algorithm stops and restarts"
• Previous message: Magnus Holmgren: "Re: Tracknum"
• In reply to: Magnus Holmgren: "Re: Tracknum"
• Next in thread: Magnus Holmgren: "Re: Tracknum"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

On Fri, 16 Aug 2002, Magnus Holmgren wrote:

> An easy fix (that seems to work) is to remove the size check in id3.c at
> line 605, that is, the "entry->id3v2len <= sizeof( entry->id3v2buf )" part.
> The ID3V2 loader will only read up to the size of the buffer anyway.

The buffer it stores the data in is only sizeof(entry->id3v2buf) bytes large,
if you remove the check it means it'll do a buffer overflow. Won't it?

-- 
Daniel "Bagder" Stenberg -- http://rockbox.haxx.se/

• Next message: Uwe Freese: "charging algorithm stops and restarts"
• Previous message: Magnus Holmgren: "Re: Tracknum"
• In reply to: Magnus Holmgren: "Re: Tracknum"
• Next in thread: Magnus Holmgren: "Re: Tracknum"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]