Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: Tracknum
From: Daniel Stenberg (daniel_at_haxx.se)
Date: 2002-08-16


On Fri, 16 Aug 2002, Magnus Holmgren wrote:

> An easy fix (that seems to work) is to remove the size check in id3.c at
> line 605, that is, the "entry->id3v2len <= sizeof( entry->id3v2buf )" part.
> The ID3V2 loader will only read up to the size of the buffer anyway.

The buffer it stores the data in is only sizeof(entry->id3v2buf) bytes large,
if you remove the check it means it'll do a buffer overflow. Won't it?

-- 
Daniel "Bagder" Stenberg -- http://rockbox.haxx.se/



Page was last modified "Jan 10 2012" The Rockbox Crew
aaa