Rockbox mail archive

• Next message: Björn Stenberg: "Re: [PATCH] mp2 filenames"
• Previous message: gizz: "Player Game.."
• Next in thread: Björn Stenberg: "Re: [PATCH] mp2 filenames"
• Reply: Björn Stenberg: "Re: [PATCH] mp2 filenames"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

I finally bought an Archos JBR20 and my first patch is to allow me to call
my Layer 2 files ".mp2".

In fact, the included patch allows all filenames ending with ".mp?". If the
maintainers don't like that, then I would suggest that ".mp3", ".mp2" and
".mpa" all be recognised as legal MPEG audio files.

I have left the TREE_ATTR_MP3 constant as it is. However, IMHO a better name
would be TREE_ATTR_MPA - for "MPeg Audio".

I have CVS write access (from my early contributions to the uisimulator), so
if no-one complains about this patch, I'll commit it. Should I make the
"MPA" change as well?

Regards,

Dave.

diff -r1.102 tree.c
216c216
< /* mark mp3 and m3u files as such */

---
>             /* mark mp? and m3u files as such */
218c218
<                 if (!strcasecmp(&entry->d_name[len-4], ".mp3"))
---
>                 if (!strncasecmp(&entry->d_name[len-4], ".mp",3))           

• Next message: Björn Stenberg: "Re: [PATCH] mp2 filenames"
• Previous message: gizz: "Player Game.."
• Next in thread: Björn Stenberg: "Re: [PATCH] mp2 filenames"
• Reply: Björn Stenberg: "Re: [PATCH] mp2 filenames"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]