Rockbox mail archive
Subject: Re: [PATCH] ff/rewind acceleration
From: Mike Soultanian (msoultan_at_csulb.edu)
Just a note, if you do cap it, could cap it at 1 minute? That way you
can still get through those 2 hour mp3 mixes relatively quickly..
Nate Nystrom wrote:
> On Wed Aug 28 09:27:13 -0400 2002, M. OReilly wrote:
> > Might I suggest that a cap be put on the doubling feature? Holding down ff
> > in a very long song could potentially be disastrous by the time one reaches
> > even 21 seconds (which will then be skipping by 128-second increments, if it
> > starts at 1 second). Perhaps a max value of ~30 seconds per second of ff?
> > ...
> > Oh, wait, I think I see it. I'm not really good at reading C code, but does
> > the FF_REWIND_MAX_STEP does exactly what I've asked above? (1000
> > milliseconds * 30)
> > If so, sorry for being redundant. :-)
> > Matt
> Oops, sorry I didn't put that constant somewhere more obvious. I just
> added that temporarily to try it out and then forgot to clean it up.
> I'm note sure if it should be a compile time option or not. I'll clean
> it up, unless someone else beats me to it.
College of the Arts
Page was last modified "Jan 10 2012" The Rockbox Crew