Rockbox mail archive

• Next message: Robert Hak: "RE: snow screensaver"
• Previous message: Daniel Stenberg: "Loadable fonts - what's still needed"
• In reply to: Bill Napier: "[PATCH] id3v2 -> overcoming 300 byte limit"
• Next in thread: Bill Napier: "[PATCH] another id3v2 patch (was Re: [PATCH] id3v2 -> overcoming 300 byte limit)"
• Reply: Bill Napier: "[PATCH] another id3v2 patch (was Re: [PATCH] id3v2 -> overcoming 300 byte limit)"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

Bill Napier wrote:
> This patch overcomes the current 300 byte limit to id3v2 tags. The
> code will now go through and read in all of you v2 tag. Those of you
> who have your titles (and other info) appearing late in your id3v2 tag
> will now be able to make use of them.

Another way would be to have the mpeg thread read the whole file (instead of skipping over the id3 tags as it does today) and then call id3info with a buffer pointer, buffer len and a file descriptor (for setid3v1title()).

Then we wouldn't need to read the file in small chunks (=more speed) and we wouldn't open it twice (=more speed). And, as a nice bonus, we'd get the whole id3v2 tag in ram, ready to parse.

-- 
Björn

• Next message: Robert Hak: "RE: snow screensaver"
• Previous message: Daniel Stenberg: "Loadable fonts - what's still needed"
• In reply to: Bill Napier: "[PATCH] id3v2 -> overcoming 300 byte limit"
• Next in thread: Bill Napier: "[PATCH] another id3v2 patch (was Re: [PATCH] id3v2 -> overcoming 300 byte limit)"
• Reply: Bill Napier: "[PATCH] another id3v2 patch (was Re: [PATCH] id3v2 -> overcoming 300 byte limit)"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]