Rockbox mail archive

• Next message: jeansebastien.tauth_at_mpsa.com: "t-shirt"
• Previous message: Benoit Midy: "Re: [PATCH] Resume from USB disconnect"
• Next in thread: Justin Heiner: "Re: Current wps.c"
• Reply: Justin Heiner: "Re: Current wps.c"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

Hi,

Don't know if this has been discussed, but there's one small detail about the current code in wps.c that bugs me: "misuse" of snprintf.

The "problem" is lines like these:

  snprintf(wps_display[l],sizeof(wps_display[l]),"%s","%fn");

Two things:

1) What's wrong with strcpy (or strncpy)?
2) You can get a "%" in the buffer by using "%%" in the format string.

(Don't take this the wrong way; it's meant as constructive critisism of what is really a minor detail.)

:)

  Magnus

• Next message: jeansebastien.tauth_at_mpsa.com: "t-shirt"
• Previous message: Benoit Midy: "Re: [PATCH] Resume from USB disconnect"
• Next in thread: Justin Heiner: "Re: Current wps.c"
• Reply: Justin Heiner: "Re: Current wps.c"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]