Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Current wps.c
From: Magnus Holmgren (lear_at_algonet.se)
Date: 2002-08-30


Hi,

Don't know if this has been discussed, but there's one small detail about the current code in wps.c that bugs me: "misuse" of snprintf.

The "problem" is lines like these:

  snprintf(wps_display[l],sizeof(wps_display[l]),"%s","%fn");

Two things:

1) What's wrong with strcpy (or strncpy)?
2) You can get a "%" in the buffer by using "%%" in the format string.

(Don't take this the wrong way; it's meant as constructive critisism of what is really a minor detail.)

:)

  Magnus



Page was last modified "Jan 10 2012" The Rockbox Crew
aaa