Rockbox mail archive
Subject: Re: Current wps.c
From: Justin Heiner (jheiner_at_yahoo.com)
My reasoning behind using the "%s","xxxx" is just for readability purposes.
It's easier to edit and update when you don't have to worry about typing %%
instead of %, especially if someone uses the WPS tag %%, which would have to be
written %%%% :-)
--- Magnus Holmgren <lear_at_algonet.se> wrote:
> Don't know if this has been discussed, but there's one small detail about the
> current code in wps.c that bugs me: "misuse" of snprintf.
> The "problem" is lines like these:
> Two things:
> 1) What's wrong with strcpy (or strncpy)?
> 2) You can get a "%" in the buffer by using "%%" in the format string.
> (Don't take this the wrong way; it's meant as constructive critisism of what
> is really a minor detail.)
Do You Yahoo!?
Yahoo! Finance - Get real-time stock quotes
Page was last modified "Jan 10 2012" The Rockbox Crew