Rockbox mail archive

• Next message: Justin Heiner: "Re: display bug"
• Previous message: Nick Robinson: "F2 Button Shuffle"
• In reply to: Magnus Holmgren: "Current wps.c"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

My reasoning behind using the "%s","xxxx" is just for readability purposes.
It's easier to edit and update when you don't have to worry about typing %%
instead of %, especially if someone uses the WPS tag %%, which would have to be
written %%%% :-)

-Justin

--- Magnus Holmgren <lear_at_algonet.se> wrote:
> Hi,
>
> Don't know if this has been discussed, but there's one small detail about the
> current code in wps.c that bugs me: "misuse" of snprintf.
>
> The "problem" is lines like these:
>
> snprintf(wps_display[l],sizeof(wps_display[l]),"%s","%fn");
>
> Two things:
>
> 1) What's wrong with strcpy (or strncpy)?
> 2) You can get a "%" in the buffer by using "%%" in the format string.
>
> (Don't take this the wrong way; it's meant as constructive critisism of what
> is really a minor detail.)
>
> :)
>
> Magnus
>

__________________________________________________
Do You Yahoo!?
Yahoo! Finance - Get real-time stock quotes
http://finance.yahoo.com

• Next message: Justin Heiner: "Re: display bug"
• Previous message: Nick Robinson: "F2 Button Shuffle"
• In reply to: Magnus Holmgren: "Current wps.c"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]