Rockbox mail archive

Subject: Re: cvs: apps menu.c,1.35,1.36 wps.c,1.126,1.127 settings.c,1.43,1.44 settings_menu.c,1.39,1.40 tree.c,1.105,1.106 wps-display.c,1.4,1.5 wps-display.h,1.2,1.3 wps.h,1.13,1.14
From: Magnus Holmgren (lear_at_algonet.se)
Date: 2002-08-31

Next message: Magnus Holmgren: "Minor quirks in CVS"
Previous message: Martin Borus: "[PATCH] ff/rewind acceleration - Comment"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

From wps.c:

> - sleep(HZ/6);
> + button = button_get(false);

<...>

> + yield();

Please, no busy loops like this when there's no need. :) Just do a
"button = button_get_w_tmo(HZ/5);" and forget the yield().

-- 
Magnus Holmgren

Next message: Magnus Holmgren: "Minor quirks in CVS"
Previous message: Martin Borus: "[PATCH] ff/rewind acceleration - Comment"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

Page was last modified "Jan 10 2012" The Rockbox Crew