Rockbox mail archive

• Next message: Magnus Holmgren: "Re: Custom WPS"
• Previous message: Magnus Holmgren: "Re: cvs: apps menu.c,1.35,1.36 wps.c,1.126,1.127 settings.c,1.43,1.44 settings_menu.c,1.39,1.40 tree.c,1.105,1.106 wps-display.c,1.4,1.5 wps-display.h,1.2,1.3 wps.h,1.13,1.14"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

Hi,

I've noticed a few quirks in the current CVS, when running on a player.

* The audio icon isn't cleared when going to the menu. It used to be
(and that's the way it should be, IMHO).

* In the "if (restore)" block at the end of wps.c, refresh_scroll in the
wps_refresh() call should be true. Otherwise it takes a little while for
the scrolling to start. (But doesn't that mean its redundant to call
both wps_display and wps_refresh?)

Fixes for the above are so simple that I haven't bothered to generate a
patch. :)

Btw, it struck me now that menu "headers" (i.e., when editing a
particular setting) aren't wrapped in "[]" the sound settings. Why the
inconcistency?

Not a quirk, but I tried the player progress. Neat thing, but should it
really progress pixel by pixel? Wouldn't pixel-line by pixel-line look
better (even if it didn't update that often) - and be easier to read?

-- 
Magnus Holmgren

• Next message: Magnus Holmgren: "Re: Custom WPS"
• Previous message: Magnus Holmgren: "Re: cvs: apps menu.c,1.35,1.36 wps.c,1.126,1.127 settings.c,1.43,1.44 settings_menu.c,1.39,1.40 tree.c,1.105,1.106 wps-display.c,1.4,1.5 wps-display.h,1.2,1.3 wps.h,1.13,1.14"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]