Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: [PATCH] ff/rewind acceleration - Comment
From: Nate Nystrom (nystrom_at_cs.cornell.edu)
Date: 2002-09-01


On Fri Aug 30 09:04:45 +0200 2002, Martin Borus wrote:
> Hi,
>
> I joined the mailing list to comment on a mail by Nate Nystrom on
> the change of the fast forward behaviour.
>
> In version 1.3 is it possible to set a fixed amount of seconds
> for fast forwarding steps. This has been changed in favor of
> an a forwarding that gets faster the longer you use it.
>
> Nate wrote:
> > we should probably combine the ff_rewind and
> > ff_rewind_accel bytes into one
> > byte. With acceleration, an ff/rewind step size
> > above, say, 15 seconds seems pretty useless to me.
>
>
> When I fount the feature I set it to 30 seconds right away and found
> it to be the killer feature why I *had* to change to RockBox.
> [snip]

OK, you've convinced me that fixed step sizes are useful in some cases.
I've added back the option to have fixed step sizes. With the attached
patch, you can select a minimum step size from 1s to 60s and also an
acceleration rate of "off" or from 2x/15s to 2x/1s, as in the current
CVS. Both the step size and acceleration rate fit in 4 bits so they are
both saved into a single byte in the RTC/disk. I've also cleaned up the
ff/rewind code to get rid of the gratuitous code duplication.

Nate



  • text/plain attachment: patch



Page was last modified "Jan 10 2012" The Rockbox Crew
aaa