Rockbox mail archive

• Next message: Magnus Holmgren: "Re: Nitpicking"
• Previous message: Chris Pimlott: "Re: Sinus and cosinus functions"
• In reply to: Chris Pimlott: "Re: [PATCH] wps-display (was Re: Custom WPS)"
• Next in thread: Chris Pimlott: "Re: [PATCH] wps-display (was Re: Custom WPS)"
• Reply: Chris Pimlott: "Re: [PATCH] wps-display (was Re: Custom WPS)"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

Chris Pimlott wrote:

> > I've removed that limitation. The format itself must (currently) fit
> > within 300 bytes. Formatting of a single line is done to a 256-byte
> > buffer (MAX_PATH actually), but that is of course only useful for the
> > scrolling line.
>
> You should #define a new constant for this. It has nothing to
> do with MAX_PATH so it shouldn't be tied to it.

You have a point there. However (from lcd.c):

struct scrollinfo {
    char text[MAX_PATH];
    /* ... */
};

:-)

-- 
Magnus Holmgren

• Next message: Magnus Holmgren: "Re: Nitpicking"
• Previous message: Chris Pimlott: "Re: Sinus and cosinus functions"
• In reply to: Chris Pimlott: "Re: [PATCH] wps-display (was Re: Custom WPS)"
• Next in thread: Chris Pimlott: "Re: [PATCH] wps-display (was Re: Custom WPS)"
• Reply: Chris Pimlott: "Re: [PATCH] wps-display (was Re: Custom WPS)"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]