Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: cvs: firmware mpeg.c,1.122,1.123
From: Eric Linenberg (elinenbe_at_umich.edu)
Date: 2002-09-13


WOWSA! This is a GREAT feature. However as with many features, there
comes some bugs.

The time display in the song is all screwey once this feature is used.

One time I got "stuck" in the pitch screen -- held down ON and then I
had to hit ON again to get out of the screen. This only happened once
however.

If you hit ON and UP or DOWN at the same time it will just start
changing the pitch WITHOUT entering the pitch screen. This is akward
behavior.

Now, here is an idea I have. When you fast forward or rewind what
about instead of playing samples of the song (I think this is what
most CD players do) play the song, and just adjust the pitch as the
ff/rw speed increases? If you don't understand I will explain more --
just ask.

-eric

BrS> Update of /cvsroot/rockbox/firmware
BrS> In directory usw-pr-cvs1:/tmp/cvs-serv2295/firmware

BrS> Modified Files:
BrS> mpeg.c
BrS> Log Message:
BrS> Added pitch setting screen for recorders. Hold ON in wps to see it. Pitch range is 50-200%

BrS> Index: mpeg.c
BrS> ===================================================================
BrS> RCS file: /cvsroot/rockbox/firmware/mpeg.c,v
BrS> retrieving revision 1.122
BrS> retrieving revision 1.123
BrS> diff -u -b -r1.122 -r1.123
BrS> --- mpeg.c 13 Sep 2002 09:26:14 -0000 1.122
BrS> +++ mpeg.c 13 Sep 2002 13:14:06 -0000 1.123
BrS> @@ -1795,8 +1795,11 @@
BrS> {
BrS> unsigned long val;
 
BrS> + /* invert percent value */
BrS> + percent = 10000/percent;
BrS> +
BrS> /* Calculate the new (bogus) frequency */
BrS> - val = 18432 - (18432*percent/100);
BrS> + val = 18432*percent/100;
     
BrS> mas_writemem(MAS_BANK_D0,0x7f3,&val,1);



Page was last modified "Jan 10 2012" The Rockbox Crew
aaa