Rockbox mail archive

• Next message: Eric Linenberg: "Re[2]: I'm out"
• Previous message: Linus Nielsen Feltzing: "Re: I'm out"
• In reply to: Mike Soultanian: "Yes/No Prompt Quirk"
• Next in thread: Mike Soultanian: "Re: Yes/No Prompt Quirk"
• Reply: Mike Soultanian: "Re: Yes/No Prompt Quirk"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

Mike Soultanian wrote:
 
> On my recorder, when you hit UP it selects NO and DOWN selects YES.
> This is slightly counter-intuitive...

Yep. It's similar on the player. The fix is easy though. In
settings.c:set_bool_options(), change:

    char* names[] = { yes_str, no_str };
    int value = !*variable;
    set_option(string, &value, names, 2, NULL);
    *variable = !value;

to

    char* names[] = { no_str, yes_str };
    int value = *variable;
    set_option(string, &value, names, 2, NULL);
    *variable = value;

which is more logical, IMO.

-- 
Magnus Holmgren

• Next message: Eric Linenberg: "Re[2]: I'm out"
• Previous message: Linus Nielsen Feltzing: "Re: I'm out"
• In reply to: Mike Soultanian: "Yes/No Prompt Quirk"
• Next in thread: Mike Soultanian: "Re: Yes/No Prompt Quirk"
• Reply: Mike Soultanian: "Re: Yes/No Prompt Quirk"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]