Rockbox mail archive

• Next message: Philipp Pertermann: "Re: Re[2]: I'm out"
• Previous message: Mike Soultanian: "Re: I'm out"
• In reply to: Magnus Holmgren: "Re: Yes/No Prompt Quirk"
• Next in thread: Magnus Holmgren: "Re: Yes/No Prompt Quirk"
• Reply: Magnus Holmgren: "Re: Yes/No Prompt Quirk"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

hehe.. if you're implying that I can go change it, I think I'd destroy
the code before I was able to actually change and compile it correctly
:) It wasn't the biggest thing in the world, I just didn't know if it
was intentional or a bug..

mike

Magnus Holmgren wrote:
>
> Mike Soultanian wrote:
>
> > On my recorder, when you hit UP it selects NO and DOWN selects YES.
> > This is slightly counter-intuitive...
>
> Yep. It's similar on the player. The fix is easy though. In
> settings.c:set_bool_options(), change:
>
> char* names[] = { yes_str, no_str };
> int value = !*variable;
> set_option(string, &value, names, 2, NULL);
> *variable = !value;
>
> to
>
> char* names[] = { no_str, yes_str };
> int value = *variable;
> set_option(string, &value, names, 2, NULL);
> *variable = value;
>
> which is more logical, IMO.
>
> --
> Magnus Holmgren

-- 
---------------------
 Mike Soultanian
 Computer Technician,
 College of the Arts
 msoultan_at_csulb.edu
 (562) 985-4409
---------------------

• Next message: Philipp Pertermann: "Re: Re[2]: I'm out"
• Previous message: Mike Soultanian: "Re: I'm out"
• In reply to: Magnus Holmgren: "Re: Yes/No Prompt Quirk"
• Next in thread: Magnus Holmgren: "Re: Yes/No Prompt Quirk"
• Reply: Magnus Holmgren: "Re: Yes/No Prompt Quirk"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]