Rockbox mail archive

• Next message: Olivier BUTLER: "RE: [PATCH] french translations"
• Previous message: Daniel Stenberg: "Using and building with the rockbox .lang files"
• Next in thread: Daniel Stenberg: "Re: cvs: firmware id3.c,1.41,1.42"
• Reply: Daniel Stenberg: "Re: cvs: firmware id3.c,1.41,1.42"
• Maybe reply: Magnus Holmgren: "Re: cvs: firmware id3.c,1.41,1.42"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

Daniel Stenberg wrote:

> Modified Files:
> id3.c
> Log Message:
> if the id3v2 tags avaiable are bigger than our buffer size, at least try
> to get the ones that is within the boundaries.

Won't work well, because the ID3 parsing loop won't detect end-of-buffer properly. Either the while statement is made more fool-proof (as it is now, "size - readsize" can wrap), or the else part in the "frame-header if-statement" needs the following code:

    if(headerlen > (size - readsize))
        headerlen = (size - readsize);

(I've encountered this problem; see http://rockbox.haxx.se/mail/archive/rockbox-archive-2002-08/0686.shtml)

  Magnus

• Next message: Olivier BUTLER: "RE: [PATCH] french translations"
• Previous message: Daniel Stenberg: "Using and building with the rockbox .lang files"
• Next in thread: Daniel Stenberg: "Re: cvs: firmware id3.c,1.41,1.42"
• Reply: Daniel Stenberg: "Re: cvs: firmware id3.c,1.41,1.42"
• Maybe reply: Magnus Holmgren: "Re: cvs: firmware id3.c,1.41,1.42"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]