Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: cvs: firmware id3.c,1.41,1.42
From: Daniel Stenberg (daniel_at_haxx.se)
Date: 2002-09-16


On Mon, 16 Sep 2002, Magnus Holmgren wrote:

> > if the id3v2 tags avaiable are bigger than our buffer size, at least try
> > to get the ones that is within the boundaries.
>
> Won't work well, because the ID3 parsing loop won't detect end-of-buffer
> properly. Either the while statement is made more fool-proof (as it is now,
> "size - readsize" can wrap), or the else part in the "frame-header
> if-statement" needs the following code:

Thanks for your heads up.

> (I've encountered this problem; see
> http://rockbox.haxx.se/mail/archive/rockbox-archive-2002-08/0686.shtml)

Wouldn't be enough to just make sure that when we encounter an unown tag, we
check that if readsize (after "readsize += headerlen") gets bigger than size,
we bail out of the loop?

-- 
Daniel "Bagder" Stenberg -- http://rockbox.haxx.se/



Page was last modified "Jan 10 2012" The Rockbox Crew
aaa