Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: cvs: firmware id3.c,1.41,1.42
From: Magnus Holmgren (lear_at_algonet.se)
Date: 2002-09-16


Daniel Stenberg wrote:

> Wouldn't be enough to just make sure that when we encounter an unown tag, we
> check that if readsize (after "readsize += headerlen") gets bigger than size,
> we bail out of the loop?

That'd work too, but why treat this case any differently? :) But with my suggestion, the bail-out is only delayed slightly (and the code could perhaps be generalized a bit?).

  Magnus



Page was last modified "Jan 10 2012" The Rockbox Crew
aaa