Rockbox mail archive

• Next message: Daniel Stenberg: "Re: cvs: firmware id3.c,1.42,1.43"
• Previous message: Nielsen Linus (ext): "RE: I'm out"
• Next in thread: Daniel Stenberg: "Re: cvs: firmware id3.c,1.42,1.43"
• Reply: Daniel Stenberg: "Re: cvs: firmware id3.c,1.42,1.43"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

Daniel Stenberg wrote:

> Modified Files:
> id3.c
> Log Message:
> When getting tag contents, we might read a tag which has a part of it within
> our buffer and part outside. This adjusts so that we only attempt to read
> the part of the tag that is inside the buffer. Magnus Holmgren helped out
> here!

Hm... Now all "if(headerlen > (size - readsize)) ..." statements within the header checks can be removed - but you've also changed what headerlen will be for a known tag that doesn't fit in the buffer (I guess we can live with that)... :)

  Magnus

• Next message: Daniel Stenberg: "Re: cvs: firmware id3.c,1.42,1.43"
• Previous message: Nielsen Linus (ext): "RE: I'm out"
• Next in thread: Daniel Stenberg: "Re: cvs: firmware id3.c,1.42,1.43"
• Reply: Daniel Stenberg: "Re: cvs: firmware id3.c,1.42,1.43"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]