dev builds
themes manual
device status forums
mailing lists
IRC bugs
dev guide

Rockbox mail archive

Subject: Re: Extending .eq
From: Magnus Holmgren (
Date: 2002-09-29

chad wrote:

> > OK, I've something that works now (on a player at least). The attached file
> > isn't a patch (since it replaces the current settings_load_eq).
> >
> > There's some room for improvement of the code though; read_line should IMO
> > be a proper function in file.c, is_numeric shouldn't need to handle
> > negative values itself, mpeg_phys2val should be moved to mpeg.c and perhaps
> > a function or two should have another name... :)
> >
> > Magnus
> Thanks I should have time this weekend to try to figuire out how this works:-)

Just a note that I've found a couple of bugs in the code and have fixed
those (and made some other changes). The new version is uploaded as a
patch on sourceforge, with ID 616125. Note that it requires the patch
616123 (improved atoi()) to work properly.

Magnus Holmgren

Page was last modified "Jan 10 2012" The Rockbox Crew