Rockbox mail archive

• Next message: Björn Stenberg: "Re: cvs: apps settings.c,1.67,1.68"
• Previous message: Paul van der Heu: "RE: user editable keys binding schemes wanted"
• Next in thread: Björn Stenberg: "Re: cvs: apps settings.c,1.67,1.68"
• Reply: Björn Stenberg: "Re: cvs: apps settings.c,1.67,1.68"
• Maybe reply: Magnus Holmgren: "Re: cvs: apps settings.c,1.67,1.68"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

Björn Stenberg wrote:

> Modified Files:
> settings.c
> Log Message:
> Changed .eq file format to simple 'setting: value' model.

Since I wrote the original patch, I just have to make a few comments. :)

The code was cleaned up a lot, which is nice, but the visual feedback and error handling is gone (and they caused much of the complexity). I'm not sure what is best though...

read_line was deliberately written to always null-terminate the buffer. That isn't the case any more, AFAICS, which could cause problems...

  Magnus

• Next message: Björn Stenberg: "Re: cvs: apps settings.c,1.67,1.68"
• Previous message: Paul van der Heu: "RE: user editable keys binding schemes wanted"
• Next in thread: Björn Stenberg: "Re: cvs: apps settings.c,1.67,1.68"
• Reply: Björn Stenberg: "Re: cvs: apps settings.c,1.67,1.68"
• Maybe reply: Magnus Holmgren: "Re: cvs: apps settings.c,1.67,1.68"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]