Rockbox mail archive

• Next message: phil_at_x-phobie.de: "key schemes: proof of concept (0/1)"
• Previous message: Magnus Holmgren: "Re: cvs: apps settings.c,1.67,1.68"
• In reply to: Magnus Holmgren: "Re: cvs: apps settings.c,1.67,1.68"
• Next in thread: Magnus Holmgren: "Re: cvs: apps settings.c,1.67,1.68"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

Magnus Holmgren wrote:
> The code was cleaned up a lot, which is nice, but the visual feedback and
> error handling is gone

Yes. I removed that, since I think it should rather be handled in tree.c after the loading is completed.

> read_line was deliberately written to always null-terminate the buffer.
> That isn't the case any more, AFAICS, which could cause problems...

    if ( count < buffer_size )
        buffer[count] = 0;

It null terminates, unless the string was completely filled. This is standard behaviour, just like strncpy etc. However, I'm inclined to agree with you that this can cause problems, since users of read_line (such as myself ;) will likely forget to check this.

-- 
Björn

• Next message: phil_at_x-phobie.de: "key schemes: proof of concept (0/1)"
• Previous message: Magnus Holmgren: "Re: cvs: apps settings.c,1.67,1.68"
• In reply to: Magnus Holmgren: "Re: cvs: apps settings.c,1.67,1.68"
• Next in thread: Magnus Holmgren: "Re: cvs: apps settings.c,1.67,1.68"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]