Rockbox mail archive

• Next message: Perron, Olivier: "[bug] Incorrect volume setting and/or value display"
• Previous message: Daniel Stenberg: "Re: Swiss German"
• Maybe in reply to: Magnus Holmgren: "Re: cvs: apps settings.c,1.67,1.68"
• Next in thread: Greg Haerr: "Re: cvs: apps settings.c,1.67,1.68"
• Reply: Greg Haerr: "Re: cvs: apps settings.c,1.67,1.68"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

Björn Stenberg wrote:

> Yes. I removed that, since I think it should rather be
> handled in tree.c after the loading is completed.

Though it's limited what can be handled there... :)

> It null terminates, unless the string was completely
> filled. This is standard behaviour, just like strncpy etc.
> However, I'm inclined to agree with you that this can cause
> problems, since users of read_line (such as myself ;) will
> likely forget to check this.

I dislike strncpy for that very reason.

Another read_line thing: a line consisting of nothing but a line feed returns 0, breaking the read... That's why I made read_line return true if something had been read.

  Magnus

• Next message: Perron, Olivier: "[bug] Incorrect volume setting and/or value display"
• Previous message: Daniel Stenberg: "Re: Swiss German"
• Maybe in reply to: Magnus Holmgren: "Re: cvs: apps settings.c,1.67,1.68"
• Next in thread: Greg Haerr: "Re: cvs: apps settings.c,1.67,1.68"
• Reply: Greg Haerr: "Re: cvs: apps settings.c,1.67,1.68"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]