Rockbox mail archive

• Next message: Björn Stenberg: "Re: Bug in CVS 021009"
• Previous message: john hill: "Re: Hardware survey"
• In reply to: Jason Williams: "Re: Bug in CVS 021009"
• Next in thread: Björn Stenberg: "Re: Bug in CVS 021009"
• Reply: Björn Stenberg: "Re: Bug in CVS 021009"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

The enclosed patch fixes this.

-Brian

Jason Williams wrote:
> It still exists in CVS 0201010
>
> Player Version 5.03 s/n 014601581
>
> More detail ....
>
> With power connected after reboot backlight will not stay on, until I go
> into the backlight on when charging setting and reapply
> then backlight will stay on. Or come on when connected to charger.
>
>
> Jason
> ----- Original Message -----
> From: "Björn Stenberg" <bjorn_at_haxx.se>
> To: <rockbox_at_cool.haxx.se>
> Sent: Thursday, October 10, 2002 11:18 AM
> Subject: Re: Bug in CVS 021009
>
>
> Jason Williams wrote:
>
>>There seems to be a slight bug in the backlight always on code, after a
>>restart the setting is restored to the menus but it is not activated the
>>back light keeps turning off until you go into the settings menu and re
>>apply the setting.
>
>
> Works for me.
>
> --
> Björn
>
>

-- 
Some days it's just not worth chewing through the restraints...

Index: settings.c
===================================================================
RCS file: /cvsroot/rockbox/apps/settings.c,v
retrieving revision 1.81
diff -u -r1.81 settings.c
--- settings.c 9 Oct 2002 23:13:23 -0000 1.81
+++ settings.c 10 Oct 2002 12:11:20 -0000
@@ -368,9 +368,7 @@
     lcd_set_contrast(global_settings.contrast);
     lcd_scroll_speed(global_settings.scroll_speed);
     backlight_set_timeout(global_settings.backlight_timeout);
-#ifdef HAVE_CHARGE_CTRL
     backlight_set_on_when_charging(global_settings.backlight_on_when_charging);
-#endif
     ata_spindown(global_settings.disk_spindown);
     set_poweroff_timeout(global_settings.poweroff);
 #ifdef HAVE_CHARGE_CTRL
@@ -657,9 +655,7 @@
     global_settings.contrast = DEFAULT_CONTRAST_SETTING;
     global_settings.poweroff = DEFAULT_POWEROFF_SETTING;
     global_settings.backlight_timeout = DEFAULT_BACKLIGHT_TIMEOUT_SETTING;
-#ifdef HAVE_CHARGE_CTRL
     global_settings.backlight_on_when_charging = DEFAULT_BACKLIGHT_ON_WHEN_CHARGING_SETTING;
-#endif
     global_settings.dirfilter = SHOW_MUSIC;
     global_settings.sort_case = false;
     global_settings.statusbar = true;

• Next message: Björn Stenberg: "Re: Bug in CVS 021009"
• Previous message: john hill: "Re: Hardware survey"
• In reply to: Jason Williams: "Re: Bug in CVS 021009"
• Next in thread: Björn Stenberg: "Re: Bug in CVS 021009"
• Reply: Björn Stenberg: "Re: Bug in CVS 021009"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]