Rockbox mail archive

• Next message: Linus Nielsen Feltzing: "Re: disk write testing"
• Previous message: Elliott, Tim: "RE: Feature Request.... Random Playlist and Standard Play...."
• In reply to: Greg Haerr: "Re: disk write testing"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

Greg Haerr wrote:
> WRT read-access updating, I wasn't trying to suggest that we have to have
> it, but rather than the current design doesn't handle it well. For instance,
> we have a "special" fat_closewrite entry point that should be just a
> fat_close entry point, handling read or write closing.

Having a fat_close() for read-only files is pointless, since there is nothing that needs to be done. Read access update could be done in fat_open(), or we'd simply add a call in file.c:close() to a new fat_close() function.

I fail to see how the absense of empty functions that do nothing is a design problem. :-)

-- 
Björn

• Next message: Linus Nielsen Feltzing: "Re: disk write testing"
• Previous message: Elliott, Tim: "RE: Feature Request.... Random Playlist and Standard Play...."
• In reply to: Greg Haerr: "Re: disk write testing"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]