Rockbox mail archive

• Next message: Linus Nielsen Feltzing: "Re: Illegal Instruction errors : 021105 and 021109 CVS builds."
• Previous message: gerald clark: "Re: Illegal Instruction errors : 021105 and 021109 CVS builds."
• In reply to: Greg Haerr: "disk write code - another bug"
• Next in thread: Greg Haerr: "Re: disk write code - another bug"
• Reply: Greg Haerr: "Re: disk write code - another bug"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

Greg Haerr wrote:
> I'm going to convert this to the buffer-cached routines over the weekend
> and see how much more code I can clean up (this will be done after I get
> the multi-sector read/write stuff working)

I recommend you post your intentions before spending many hours rewriting the code. You still have not shown us how your code will work, and be substantially simpler.

The only thing I have seen so far is your consolidated buffer code. And you haven't told us how you will change it so it does not hurt performance.

Lets avoid repeating the font incident we had earlier, where one person spent a lot of time rewriting code in isolation and then became angry when I didn't accept his big patch.

-- 
Björn

• Next message: Linus Nielsen Feltzing: "Re: Illegal Instruction errors : 021105 and 021109 CVS builds."
• Previous message: gerald clark: "Re: Illegal Instruction errors : 021105 and 021109 CVS builds."
• In reply to: Greg Haerr: "disk write code - another bug"
• Next in thread: Greg Haerr: "Re: disk write code - another bug"
• Reply: Greg Haerr: "Re: disk write code - another bug"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]