Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: RE: Book Marking Functionality
From: Benjamin (mailinglists_at_samuraipanda.com)
Date: 2003-01-13


Grumble, grumble. Okay, like I said, I didn't test it that much and as
I was now testing it more thoroughly, I found a bug. Once I fix it, the
updated file will be offline. The earlier stuff will remain up though.

Ben

-----Original Message-----
From: owner-rockbox_at_cool.haxx.se [mailto:owner-rockbox_at_cool.haxx.se] On
Behalf Of Benjamin
Sent: Sunday, January 12, 2003 1:50 PM
To: rockbox_at_cool.haxx.se
Subject: RE: Book Marking Functionality

Easily enough done and it makes sense. I went ahead and did it. You
can find a copy of the firmware and changed source files at:
http://www.samuraipanda.com/autobookmark.zip. This will automatically
generate bookmark for any file playing when you stop the playback (via
the off button). I'll add a setting to the global_settings and the
bookmark menu to enable or disable auto-bookmark similar to the resume
functionality. Let me know if this is what you were thinking.

The basic logic is this:
1. In tree.c, if you select a MP3 or M3U file, it will call a function
called bookmark_autoload which will check for a bookmark file based off
of the selected file (i.e. foo.mp3 will cause it to look for
foo.mp3.bmf). If one exists, then it will prompt the user if they wish
to resume at the bookmark. If the user does, it will load the bookmark
file and play that instead of the selected file. Otherwise, it will
play the selected file. 2. While a file is playing, if you select the
off button, it will call
bookmark_create() which will create a bookmark file based on the file
name (i.e. foo.m3u will create a bookmark file called foo.m3u.bmf).
3. For now, you must enable resume to "Yes", until I can write my own
play function in bookmark.c. 4. This new implementation will
automatically overwrite any existing bookmark, so there is only one
bookmark for any given MP3/M3U at any given time.

I haven't tested this new implementation that much, so mileage may vary.

Ben

-----Original Message-----
From: owner-rockbox_at_cool.haxx.se [mailto:owner-rockbox_at_cool.haxx.se] On
Behalf Of Vincent Kargatis
Sent: Sunday, January 12, 2003 8:20 AM
To: rockbox_at_cool.haxx.se
Subject: Re: Book Marking Functionality

From: "Benjamin Metzler" <ben_at_samuraipanda.com>
> How to create a bookmark:
> ---------------------------------------------
> 1. Start an MP3/M3U running.
> 2. Goto the main menu (F1 on the Recorder 20). The first item will be

> "Create A Bookmark". Select it.
>
> How to load a bookmark:
> ---------------------------------------------
> 1. Locate the bookmark file you want to load. It will have a BMF
> extension. 2. Select the bookmark file by clicking the Play button.

Although bookmarking (playlists) is my most desired feature, this to me
seems way too cumbersome for usability. Automatic bookmarking is
essential for this capability imo. Basically (see the bookmarking
feature request for more), when you STOP a playlist, it auto-bookmarks
the resume location, and when you next PLAY a playlist, it looks for an
extant bookmark and asks if you want to resume. I would find that
useful - having to consciously bookmark a playlist every time I STOP it
would be very cumbersome. Additionally, I can't imagine how anyone would
find the auto-bookmark cumbersome.

v



Page was last modified "Jan 10 2012" The Rockbox Crew
aaa