Rockbox mail archive

• Next message: Joaquim Carvalho: "How can you stand carrying the power supply around?"
• Previous message: Benoit Midy: "RE: Bookmarking Help"
• In reply to: Benoit Midy: "RE: Bookmarking Help"
• Next in thread: Benjamin: "Re: Bookmarking Help"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

Benoit Midy wrote:
> Hi,
>
> Firstly I want to thnaks the people who contribute to make this first code for the bookmark.
>
> And now some comments about the way to make it :
>
> - I think that the idea to store all the .BMF files in one place could make some problem for people having duplicates filenames.

It doesn't. It creates a new .bmf file with the same name and location as the mp3 or m3u file.

> - Another idea is to make it possible to get a bookmark menu through the F3 key :
> It will display a screen menu with many choice :
> - Create New Bookmark
> - Bookmark 1
> - Bookmark 2

Currently you get it when you press STOP in the WPS. I agree, though, that we should have the option of creating several bookmarks. Otherwise it's just a "multi-resume" and not a real bookmark feature. This also means we need to be able to remove one or more bookmarks from the bookmark file.

Some comments on the code, now that I've looked at it:

- Please split lines longer that 80 columns
- I'd prefer using a comma instead of asterisk as value delimiter in the file
- There is no need restricting ourselves to a 3-char extension. Quite the opposite, I bet $10 .bmf is already used some obscure windows applications. How about using .bmark instead? (The full .bookmark might be a bit longish.)
- Don't use C++ comments.
- Don't leave commented-out code in the file.

-- 
Björn

• Next message: Joaquim Carvalho: "How can you stand carrying the power supply around?"
• Previous message: Benoit Midy: "RE: Bookmarking Help"
• In reply to: Benoit Midy: "RE: Bookmarking Help"
• Next in thread: Benjamin: "Re: Bookmarking Help"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]