|
Rockbox mail archiveSubject: RE: Compiled Bookmarks FirmwareRE: Compiled Bookmarks Firmware
From: Benjamin <mailinglists_at_samuraipanda.com>
Date: Thu, 23 Jan 2003 13:50:23 -0800 Thank you kindly, sir. I've modified the source to no longer allow creating or loading bookmarks (except via a bookmark file) while playing a queued file. This is because bookmarking a queue doesn't make sense because of it's changing nature. A new diff has been submitted and a new compiled version is available at http://www.samuraipanda.com/bookmarks.zip. Ben At Thursday, 23 January 2003, you wrote: >Hi Benjamin, > >Check for QUEUE_BEGIN_QUEUE -- this identifies the >index passed as belonging to the queue list. >QUEUE_BEGIN_PLAYLIST is used when the _next_ song >should be played from the queue (needed for resume to >know where to begin playing). > >-Hardeep > >--- Benjamin <mailinglists_at_samuraipanda.com> wrote: >> My assumption would be to check if >> playlist_get_resume_info() returns >> QUEUE_BEGIN_PLAYLIST. If so, I wouldn't allow a >> bookmark to occure. >> The reason behind this would be because the queue >> will change from >> time to time and therefor it would be un-reliable to >> bookmark it. >> >> >> Does this make sense? >> >> Ben >> >> At Thursday, 23 January 2003, you wrote: >> >> >Hi Benjamin, >> > >> >This variable already exists. You should be >> calling >> >playlist_get_resume_info() to get information for >> your bookmark. >> You'll >> >notice that the second argument of this function >> indicates whether >> or not >> >the current song is a queued song. >> > >> >-Hardeep >> > >> >> -----Original Message----- >> >> From: owner-rockbox_at_cool.haxx.se >> [mailto:owner-rockbox_at_cool.haxx. >> se]On >> >> Behalf Of Benjamin >> >> Sent: Thursday, January 23, 2003 9:44 AM >> >> To: rockbox_at_cool.haxx.se >> >> Subject: Re: Compiled Bookmarks Firmware >> >> >> >> >> >> I just tried queueing a couple of times. What >> seems to happen is >> >> that the bookmark is created with the current MP3 >> information >> (elapsed >> >> time, Title), but when it plays, it plays the MP3 >> directory that >> >> the bookmark is for. This makes sense since the >> queue information >> >> is stored in a seperate file. I think a possible >> solution for this >> >> is to have a lobal variable called in_queue which >> would essentially >> >> indicate to the bookmark (and any other future) >> code that this is >> >> not in a standard playlist and shouldn't be >> bookmarked. Just >> a thought. >> >> >> >> >> >> Ben >> >> >> >> >> >> >> >> >> >> >> >> >> > >> >> >> >> >> >> >> >> > Received on 2003-01-23 Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy |