|
Rockbox mail archiveSubject: Re: Player WPS scrollingRe: Player WPS scrolling
From: Kjell Ericson <Kjell.Ericson_at_haxx.se>
Date: Wed, 29 Jan 2003 20:47:12 +0100 (CET) On Wed, 29 Jan 2003, gizz wrote: > It seems that WPS scrolling doesn't function anymore on Players. Good observation! -----start snip---- Date: Tue, 28 Jan 2003 09:00:58 -0800 From: Daniel Stenberg <bagder_at_users.sourceforge.net> Modified Files: wps-display.c Log Message: avoid division by zero (appears in the sim at times) fixed dynamicly updated scrolling lines - flags=0; ----end snip---- To Daniel: That "flags=0" is highly necessary in the Player in this case. The reason is that (unlike the Recorder) we stop any scroll at a line where you do lcd_puts(). When I start playing a tune in the Recorder (simulator) I can see one call to lcd_puts_scroll() followed by two calls to lcd_puts(), which then is repeated three times. One of the lcd_puts is probably called from the lcd_puts_scroll but that still leaves you with one unnecessary lcd_puts(). You told me (face2face) that I've missunderstood something with the "flags"-variable. So I'm not changing this at the moment. // Kjell Received on 2003-01-29 Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy |