Rockbox mail archiveSubject: Re: Bookmarks
From: Björn Stenberg (bjorn_at_haxx.se)
That's not a problem if you put the path+filename last on the line. No matter which separator you choose, you will always have a problem trying to split free-text like filenames. So don't try; put it last on the line.
> Also, there are now two fields that are text based,
Don't split the path, use /path/file.mp3. If someone wants to split it later, it's done with a simple call to strrchr().
> I didn't want to have to read through a file just to find the single
Yeah, but it doesn't work if you create a bookmark manually for a file that doesn't have an auto-bookmark. The next time you play that file with auto-bookmark enabled, your manually created bookmark will be destroyed.
> >- Move all strings to the english.lang file
It's very simple. Add these lines to lang/english.lang for each new string:
Then in the code, you use the string as this:
> >- Fix the code to work on players too
We have a simulator for this purpose. It handles all GUI issues like the real thing.
> >Additionally, I want to separate between file and playlist bookmarks.
That is correct, but that is not how the users perceive it. I, as a user, wish to bookmark a specific position in a specific song. The next time I hear that song, I want to be able to go to my bookmark. I don't care which playlist I played the song from when the bookmark was created. I bookmarked the song, not the playlist.
> My main concern with a centralized is the duplication of the file name
I agree. We'll have to ask the proponents of centralised bookmarks how they want it.
Page was last modified "Jan 10 2012" The Rockbox Crew