Rockbox.org home
Downloads
release
dev builds
extras
themes
Documentation
manual
wiki
device status
Support
forums
mailing lists
IRC
Development
bugs
patches
dev guide
Search



Rockbox mail archive

Subject: RE: Latest Bookmarking Patch
From: Daniel Stenberg (daniel_at_haxx.se)
Date: 2003-02-01

On Sat, 1 Feb 2003, Benjamin wrote:

Hi Benjamin!

Thanks for all your work on this feature. I do however have some remarks on
your recent patch (dated feb 1 2003):

* It still contains CRLF newlines all over.

* On several places in the code you have changed a section like:

  if(global_settings.resume)
    bla-bla;

  with your new code that looks like this:

  if(bookmark_autoload)
    your stuff;
  else
    bla-bla;

  Evidently, you alter the flow and I'm not convinced that you should do
  that. Is it on purpose?

* I suggest you use button_get(true) instead of button_get_w_tmo() if you're
  not gonna do anything special after the timeout has elapsed.

* The bookmark_debug_print() function should probably be replaced with
  DEBUGF() in case you really want it to remain.

Otherwise I think it looks mighty fine! 

-- 
 Daniel Stenberg -- http://rockbox.haxx.se/ -- http://daniel.haxx.se/

Page was last modified "Jan 10 2012" The Rockbox Crew
aaa