Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: Recorder experimental new UI, Sound Sliders and larger Tetris source code
From: Joaquim Carvalho (jdc_at_x64.com)
Date: 2003-02-21


On Fri, 2003-02-21 at 11:20, Daniel Stenberg wrote:
> On Fri, 21 Feb 2003, Joaquim Carvalho wrote:
>
> > The following patches are based on the Rockbox 1.4 release.
>
> [snip]
>
> > http://x64.com/public/ui.patch
> > - ui.patch
> > - Global keys [On] [F1] [F2] [F3] go to
> > Brouse Sound_Sliders Menu and WPS screens
> > - Inverted line cursor
> > - Improved some icons
> > - Volume setup "linearized" for very low volume levels
> > Resolution has not been lost above 60%
> > - also contains the tetris and sound sliders patch
>
> IMHO, this is way too much functionaliy in one single patch.
>
> We need to be able to pick and apply single changes at will, not going with a
> one huge monster patch that does 511 different things.
>
> We prefer ONE patch fixing ONE thing, otherwise you'll handle over a lot of
> extra work on us.
>
> (I'm not saying I appreciate your work. I think you've done a great job and I
> am certain most - if not all - of it will find its way into the sources.)

I did it all at once in a few hours, then I took some further
time improving it and correct bugs. The sound sliders screen can
be separated by applying the complete patch and discarding all files
but sound_menu.c

Joaquim



Page was last modified "Jan 10 2012" The Rockbox Crew
aaa