Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: Recorder experimental new UI, Sound Sliders and larger Tetris source code
From: Robert Hak (rhak_at_ramapo.edu)
Date: 2003-02-21


---quote---
> Why do you replace proper C comments /* */ with C++isms of //?
>
There's a good reason for // commenting:
---unquote--

I realize the reason why you did the // what I mean is it is not
acceptable for a patch.

---quote---
> Also, use the patch tracker if you want to submist patches.

I'm knew to this, didn't know there was a patch tracker.
---unquote---

Welcome to the group :)

---quote---
I mailed the patches to the list because I was asked to do it.
The base code is version 1.4, the patches have to be changed
to be applied to the current version.
I posted the compiled code for evaluation, if the patches are
to be applied I'll re-do them for the current version.
---unquote---

I'd go the other way. We can't consider patches for inclusion until we
see them based off the current code (well.. more current then 1.4)

Try and convert what you have to several small patches and put them in.
You are much more likely to get them accepted. "I'll do it once they are
accepted" won't gain you much ground.

/Adi



Page was last modified "Jan 10 2012" The Rockbox Crew
aaa