Rockbox mail archive

• Next message: Linus Nielsen Feltzing: "Re: Recorder experimental new UI, Sound Sliders and largerTetrissource code"
• Previous message: Björn Stenberg: "Re: What do you think of this?"
• In reply to: Björn Stenberg: "Re: code style - my take"
• Next in thread: shane wright: "Re: comments"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

Björn Stenberg wrote:
> Joaquim Carvalho wrote:
>
>> http://rockbox.haxx.se/docs/contributing.html says nothing about //
>> comments not being allowed.
>
>
> No, but it says "follow the code style of the file you are editing"
> and all our files use C comments exclusively.

Not entirely true. Quite a few // comments have escaped the Code Police.
Look in lcd.c, lcd-recorder.c and system.c. :-)

> Exactly. That's why we have defined a right way for Rockbox. Please
> follow it.
>
> You will not convince me to change the Rockbox coding style, so stop
> trying. Let's move on to more important things.
>

I agree. And I still think #ifdef is far better that /* */ to comment
out code. :-)

/Linus

• Next message: Linus Nielsen Feltzing: "Re: Recorder experimental new UI, Sound Sliders and largerTetrissource code"
• Previous message: Björn Stenberg: "Re: What do you think of this?"
• In reply to: Björn Stenberg: "Re: code style - my take"
• Next in thread: shane wright: "Re: comments"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]