Rockbox mail archive

• Next message: Björn Stenberg: "Re: cvs: firmware mpeg.c,1.204,1.205"
• Previous message: Charlie Rosenthal: "1 big directory to smaller ones on JBR FM"
• Next in thread: Björn Stenberg: "Re: cvs: firmware mpeg.c,1.204,1.205"
• Reply: Björn Stenberg: "Re: cvs: firmware mpeg.c,1.204,1.205"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

Linus Nielsen Feltzing wrote:

> Update of /cvsroot/rockbox/firmware
> In directory sc8-pr-cvs1:/tmp/cvs-serv14054/firmware
>
> Modified Files:
> mpeg.c
> Log Message:
> Now correctly skips ID3V1 tags to avoid gaps between tracks

Hm... Wouldn't it be simpler to use id3v1len to avoid reading the data
in the first place? (Naturally, this assumes the field is actually set
in id3.c.) Or is that the "simple, neat and wrong" solution for this
problem? :)

-- 
Magnus Holmgren

• Next message: Björn Stenberg: "Re: cvs: firmware mpeg.c,1.204,1.205"
• Previous message: Charlie Rosenthal: "1 big directory to smaller ones on JBR FM"
• Next in thread: Björn Stenberg: "Re: cvs: firmware mpeg.c,1.204,1.205"
• Reply: Björn Stenberg: "Re: cvs: firmware mpeg.c,1.204,1.205"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]