Rockbox mail archive

Subject: Re: cvs: firmware mpeg.c,1.204,1.205
From: Björn Stenberg (bjorn_at_haxx.se)
Date: 2003-03-02

Next message: Magnus Holmgren: "Re: cvs: firmware mpeg.c,1.204,1.205"
Previous message: Magnus Holmgren: "Re: cvs: firmware mpeg.c,1.204,1.205"
In reply to: Magnus Holmgren: "Re: cvs: firmware mpeg.c,1.204,1.205"
Next in thread: Magnus Holmgren: "Re: cvs: firmware mpeg.c,1.204,1.205"
Reply: Magnus Holmgren: "Re: cvs: firmware mpeg.c,1.204,1.205"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

Magnus Holmgren wrote:
> Hm... Wouldn't it be simpler to use id3v1len to avoid reading the data
> in the first place? (Naturally, this assumes the field is actually set
> in id3.c.)

The problem is that this field is only set if the file does not have an id3v2 tag. A while back we stopped looking for a v1 tag if a v2 tag is present.

-- 
Björn

Next message: Magnus Holmgren: "Re: cvs: firmware mpeg.c,1.204,1.205"
Previous message: Magnus Holmgren: "Re: cvs: firmware mpeg.c,1.204,1.205"
In reply to: Magnus Holmgren: "Re: cvs: firmware mpeg.c,1.204,1.205"
Next in thread: Magnus Holmgren: "Re: cvs: firmware mpeg.c,1.204,1.205"
Reply: Magnus Holmgren: "Re: cvs: firmware mpeg.c,1.204,1.205"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

Page was last modified "Mar 9 2008" The Rockbox Crew