Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: cvs: firmware mpeg.c,1.204,1.205
From: Linus Nielsen Feltzing (linus_at_haxx.se)
Date: 2003-03-02


Magnus Holmgren wrote:
> Hm... The code won't properly handle the case when less than 128
> bytes are read, will it (tag is missed; wrong memory checked)? I
> imagine it doesn't happen very often, so maybe it isn't worth
> fixing...

Maybe we should try to, but I'll let it be for now.

> On the other hand, why bother skipping the ID3V1 tag? The MP3 format
> just doesn't support gapless playback anyway. And I do wonder long
> it takes for the MP3 decoder to sync to the next frame in this case.
> :)

It is a concern for those people who use the --nogap option to LAME, or
who split their MP3 files in an editor. Lots of people care.

The resynchronisation causes a short silent gap. That's why we remove
the tag.

/Linus



Page was last modified "Jan 10 2012" The Rockbox Crew
aaa