Rockbox mail archive

• Next message: Daniel Stenberg: "Re: cvs: firmware mpeg.c,1.206,1.207"
• Previous message: Bengt Ritover: "Difference between JBR 10 and 20?"
• Next in thread: Daniel Stenberg: "Re: cvs: firmware mpeg.c,1.206,1.207"
• Reply: Daniel Stenberg: "Re: cvs: firmware mpeg.c,1.206,1.207"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

Uwe Freese wrote:
> Found the only one point that led to imcompatibility of the CVS code with
> a 8MB AJB. Finally, CVS is 8 MB-mod compliant. :-)

> amount_to_read = MIN(mp3buflen - mp3buf_write, amount_to_read);
> +#if MEM == 8
> + amount_to_read = MIN(0x100000, amount_to_read);
> +#endif

Could you explain why the old code did not work? Your change replaces the dynamic buffer space calculation with a static 0x100000 read. Why? This should not be necessary.

-- 
Björn

• Next message: Daniel Stenberg: "Re: cvs: firmware mpeg.c,1.206,1.207"
• Previous message: Bengt Ritover: "Difference between JBR 10 and 20?"
• Next in thread: Daniel Stenberg: "Re: cvs: firmware mpeg.c,1.206,1.207"
• Reply: Daniel Stenberg: "Re: cvs: firmware mpeg.c,1.206,1.207"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]