Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: cvs: firmware mpeg.c,1.206,1.207
From: Daniel Stenberg (daniel_at_haxx.se)
Date: 2003-03-03


On Mon, 3 Mar 2003, Björn Stenberg wrote:

> > +#if MEM == 8
> > + amount_to_read = MIN(0x100000, amount_to_read);
> > +#endif
>
> Could you explain why the old code did not work? Your change replaces the
> dynamic buffer space calculation with a static 0x100000 read. Why? This
> should not be necessary.

As I was saying already before, the 8MB version may need different
thresholds. It should *not* require different code... AFAICT.

-- 
 Daniel Stenberg -- http://rockbox.haxx.se/ -- http://daniel.haxx.se/



Page was last modified "Jan 10 2012" The Rockbox Crew
aaa