Rockbox mail archive

• Next message: Samuel Kaufman: "Re: pauses between songs"
• Previous message: Björn Stenberg: "Re: cvs: firmware mpeg.c,1.206,1.207"
• In reply to: Björn Stenberg: "Re: cvs: firmware mpeg.c,1.206,1.207"
• Next in thread: Uwe Freese: "Re[2]: cvs: firmware mpeg.c,1.206,1.207"
• Reply: Uwe Freese: "Re[2]: cvs: firmware mpeg.c,1.206,1.207"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

On Mon, 3 Mar 2003, Björn Stenberg wrote:

> > +#if MEM == 8
> > + amount_to_read = MIN(0x100000, amount_to_read);
> > +#endif
>
> Could you explain why the old code did not work? Your change replaces the
> dynamic buffer space calculation with a static 0x100000 read. Why? This
> should not be necessary.

As I was saying already before, the 8MB version may need different
thresholds. It should *not* require different code... AFAICT.

-- 
 Daniel Stenberg -- http://rockbox.haxx.se/ -- http://daniel.haxx.se/

• Next message: Samuel Kaufman: "Re: pauses between songs"
• Previous message: Björn Stenberg: "Re: cvs: firmware mpeg.c,1.206,1.207"
• In reply to: Björn Stenberg: "Re: cvs: firmware mpeg.c,1.206,1.207"
• Next in thread: Uwe Freese: "Re[2]: cvs: firmware mpeg.c,1.206,1.207"
• Reply: Uwe Freese: "Re[2]: cvs: firmware mpeg.c,1.206,1.207"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]