Rockbox mail archive

• Next message: Michael Schopferer: "Re: New patch: autopreset of RTC after power-loss"
• Previous message: Johan Vromans: "Re: New patch: autopreset of RTC after power-loss"
• Next in thread: Mike Holden: "Re: [ rockbox-Patches-699202 ] Custom Recording Filenames"
• Maybe reply: Mike Holden: "Re: [ rockbox-Patches-699202 ] Custom Recording Filenames"
• Maybe reply: Greg Haerr: "Re: [ rockbox-Patches-699202 ] Custom Recording Filenames"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

SourceForge.net said:
> Patches item #699202, was opened at 2003-03-06 23:08
> You can respond by visiting:
> https://sourceforge.net/tracker/?func=detail&atid=439120&aid=699202&group_id=44306
>

First comment:
I get a compilation warning:
recorder/recording.c: In function `create_filename':
recorder/recording.c:301: warning: operation on `fmtPtr' may be undefined

You have a bit of code: *fmtPtr++ which perhaps should be *(fmtPtr++) as *
takes precedece over ++, which I think is probably not what you want! You
want to increment the pointer, then dereference it, whereas the code is
trying to dereference then increment the contents!

-- 
Mike Holden

• Next message: Michael Schopferer: "Re: New patch: autopreset of RTC after power-loss"
• Previous message: Johan Vromans: "Re: New patch: autopreset of RTC after power-loss"
• Next in thread: Mike Holden: "Re: [ rockbox-Patches-699202 ] Custom Recording Filenames"
• Maybe reply: Mike Holden: "Re: [ rockbox-Patches-699202 ] Custom Recording Filenames"
• Maybe reply: Greg Haerr: "Re: [ rockbox-Patches-699202 ] Custom Recording Filenames"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]