Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: New patch: autopreset of RTC after power-loss
From: Michael Schopferer (michael.schopferer_at_stud.uni-karlsruhe.de)
Date: 2003-03-07


On Fri, Mar 07, 2003 at 09:36:10AM +0100, Bj?rn Stenberg wrote:
> Michael Schopferer wrote:
> > This patch checks the values of the RTC in settings_load in settings.c
>
> Sounds like an excellent approach.
>
> > config_block[0xa1] = /* seconds */
> > config_block[0xa2] = /* minutes */
> > config_block[0xa3] = /* hour */
> > config_block[0xa4] = /* dayofweek */
> > config_block[0xa5] = /* day */
> > config_block[0xa6] = /* month */
> > config_block[0xa7] = /* year */
>
> You should pack this a bit more.

Ok, will do it soon. I'll have to submit it as a new item while I wasn't
logged in to sourceforge. But you'll get it...

> > Now I'm working on a DaylightSavingTime-patch (DST).
> > In the Time/Date-Setting toogles a PLAY-push between summertime/wintertime
>
> I question the benefit of adding DST handling in Rockbox. If you need to
> toggle the bit manually, why not just change the hour field instead?
> Very very few devices bother with DST. Most digital clocks/watches, whose
> single purpose for existing is showing the time, don't even care about DST.
> Why then should we?

There was a line:
"tm.tm_isdst = -1; /* Not implemented for now */"
So, I thought "Why don't YOU implement it?"

But after some sleep now I can also find no further benefit. With my idea, it
will not be easier to change the hour. So I'll drop it...

Another things, I'm working on:
* An option in the Sleeptimer to change between switch off and only stop playing.
* combine Sleeptimer with Wake Up.

Ciao,
Michael

-- 
Michael Schopferer *** Michael.Schopferer_at_stud.uni-karlsruhe.de



Page was last modified "Jan 10 2012" The Rockbox Crew
aaa