From: Mike Holden <rockbox_at_mikeholden.uklinux.net>
Date: Fri, 7 Mar 2003 10:11:12 -0000 (GMT)

SourceForge.net said:
> Patches item #699202, was opened at 2003-03-06 23:08
> You can respond by visiting:
> https://sourceforge.net/tracker/?func=detail&atid=439120&aid=699202&group_id=44306
>
> Category: settings
> Group: None
> Status: Open
> Resolution: None
> Priority: 5
> Submitted By: Jeremy Zoss (jzoss)
> Assigned to: Nobody/Anonymous (nobody)
> Summary: Custom Recording Filenames
>
> Initial Comment:
> This patch allows the user to specify a custom
> recording filename, using a syntax similar to WPS.

Works great. Couple of comments:

Editing of filename is cumbersome. Would be good to have an extra screen
which listed the % tags and you could choose each one directly,
especially as % and lc letters are on different pages. As a general
comment on the keyboard stuff, would be good to be able to move the cursor
left and right directly, rather than delete to move back.

When recording without the leading / on the filename, the recording is
correctly located in the current directory. When you exit the recording
screen however, you should be in the same directory you were in when you
started. The following patch to tree.c will fix this:
--- tree.c 2003-03-07 09:04:17.000000000 +0000
+++ tree.c.mrh 2003-03-07 08:44:53.000000000 +0000
_at__at_ -1284,7 +1284,7 _at__at_
             case TREE_MENU:
                 lcd_stop_scroll();
                 if (main_menu())
- reload_root = true;
+ reload_dir = true;
                 restore = true;
                 break;

This may be more of a generic patch however, and maybe should be added
anyway to the main CVS code, rather than specifically to this patch.
This is the case when you go into any menu items that return "true", not
just recording.

-- 
Mike Holden

Received on 2003-03-07